Drop column sp_return_logs.requested_at#12025
Merged
Conversation
changelog: Internal, Events, Drop column sp_return_logs.requested_at Step 3 of 3 Steps: 1. Add migration to drop the NOT NULL constraint and deploy 2. Add column to `ignored_columns`, remove all reads and writes and deploy 3. Drop column using `safety_assured` and deploy
vrajmohan
force-pushed
the
vm-remove-requested-at-from-sp-return-log-3
branch
from
1133b09 to
b7d4f91
Compare
kevinsmaster5
approved these changes
Mar 26, 2025
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
It looks good.
Just for my own PR review development, for a DB change like this I'd want to make sure that if you dropped a column that there isn't an index for that column left behind, correct?
Contributor
Author
|
They should be automatically dropped as well, see https://www.postgresql.org/docs/16/sql-altertable.html#SQL-ALTERTABLE-DESC-DROP-COLUMN. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Events, Drop column sp_return_logs.requested_at
Step 3 of 3
Steps:
ignored_columns, remove all reads and writes and deploysafety_assuredand deploy🎫 Ticket
Link to the relevant ticket:
LG-13781