Improve test reliability by adding page assertions in feature test helpers#12016
Merged
mitchellhenke merged 1 commit intomainfrom Mar 31, 2025
Merged
Improve test reliability by adding page assertions in feature test helpers#12016mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/more-reliable-test
branch
2 times, most recently
from
cf56e84 to
c7f5e07
Compare
Sgtpluck
approved these changes
Mar 24, 2025
…lpers changelog: Internal, Testing, Improve test reliability by adding page assertions in feature test helpers
mitchellhenke
force-pushed
the
mitchellhenke/more-reliable-test
branch
from
c7f5e07 to
f063900
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Based on reports here where a test attempts to go to the next page before completing authentication. Adding some additional assertions around page expectations addresses the issue for me locally. We don't see the issue in CI, so I suspect it's due to the speed of the system, and adding assertions makes sure requests can complete before moving on to the next step in the test.