Skip to content

Wiring up first attempt event#12028

Merged
Sgtpluck merged 4 commits intomainfrom
dmm/first-event
Mar 27, 2025
Merged

Wiring up first attempt event#12028
Sgtpluck merged 4 commits intomainfrom
dmm/first-event

Conversation

@Sgtpluck
Copy link
Copy Markdown
Contributor

🎫 Ticket

Link to the relevant ticket:
154

🛠 Summary of changes

This change wires in the first attempt event to be stored in Redis. This code:

  • Adds an attempts_api_tracker object in the applications controller
  • Adds a way to access the attempts_api_session_id from the session object
  • wires in a call to the email_and_password_auth event

I tested it locally using the OIDC sinatra sample app. I want to add a view there to make it easy to see events as they are generated/delete them

@Sgtpluck Sgtpluck requested a review from mitchellhenke March 26, 2025 17:50
Copy link
Copy Markdown
Contributor

@mitchellhenke mitchellhenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor suggestions, but looks good!

Sgtpluck and others added 2 commits March 27, 2025 10:44
Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
@Sgtpluck Sgtpluck merged commit 3e2e837 into main Mar 27, 2025
1 check passed
@Sgtpluck Sgtpluck deleted the dmm/first-event branch March 27, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants