Merged
Conversation
* changelog: Internal, Lexis Nexis request, add user uuid to local_attrib_3 * update request json to be a valid value * fix spec * update setup concern * add uuid for idv * update threatmetrix plugin spec * update spec
…he applicant (#11950) We are working on a feature where the user's phone number can be verified in the verify-info check. This feature is called "Phone Finder Pre-check". Phone-Finder Pre-check will make a best effort to find a phone number on the user's account (either from their MFA methods or hybrid flow) and validated that phone number when the user submits their info. If the number matches the user will be sent straight to OTP confirmation for that phone number. As part of this implementation we will need the resolution proofing job to send the phone number to phone finder if a phone number is found for the user at the verify info step. This commit implements that by have the resolution proofing job communicate with phone finder and store a result if a phone number is provided in the applicant. [skip changelog]
* Updates to IPP h1 current address * changelog: User-Facing Improvements, In-person proofing, Update H1 text on Residential Address on update
…#11960) We often get requests for data that involve searching for accounts that share devices. These kinds of requests occur more often than not. Currently we default to not searching for shared devices. This has led to mistakes where we did not provide shared account data. This commit attempts to address the issue by making the `--depth` argument required. This will require investigators to explicitly opt-in or out of shared device searches. The `exit 1` in `lib/script_base.rb` was causing some rather opaque failures in CI as it sets the status code to 1 and caused some tests to end early rather without reporting whether they failed. The unhelpful message at the end of a CI run was Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected. This only became an issue because the PR added a case where we raise an exception and it resulted in a non-zero status code. [skip changelog] Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
* create choose_id_type_controller * create choose_id_type page * add flow policy for choose_id_type and allow redirects to id page * use idv_session variables for passports * add analytics events and form error messages * create specs * styling for radio button * lint fixes * add changelog changelog: Upcoming Features, Doc Auth, add a choose your id screen for passports * Updated page styling * switching to usa-radio__input--tile * Added spacing * Updating spacing * Adding choose id to mobile flow * Fixing specs and mobile flow * updating specs for new behaviours * Resolving PR comment * Resolving PR comment * Resolved PR comments, fixing specs * Fixing specs * Fixing lint and feature tests * Updated spec to choose radio option and continue to doc capture --------- Co-authored-by: ashukla <abir.shukla@gsa.gov>
As part of the phone-finder pre-check work the user can arrive on the phone warning screen without entering a number. In this case the "You entered (XXX) XXX-XXXX" message on the screen does not make sense. This commit changes the message to say "We couldn't find a record of you using this number: (XXX) XXX-XXXX". [skip changelog]
…erification controller (#11958) As part of the phone-finder pre-check work the user can arrive on the OTP verification screen without entering a number. In this case the "Entered the wrong number" message on the screen does not make sense. This commit removes the message and leaves the link that allows a user to try a different number. [skip changelog]
…11957) changelog: Internal, In-person Proofing, Permanently enable the pending in person password reset feature
mitchellhenke
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal
Upcoming Features