Merged
Conversation
anniehirshman-gsa
approved these changes
Mar 5, 2025
Contributor
anniehirshman-gsa
left a comment
anniehirshman-gsa
left a comment
There was a problem hiding this comment.
Reviewed changes in the solipet environment and LGTM - thank you!
jmax-gsa
approved these changes
Mar 7, 2025
Contributor
jmax-gsa
left a comment
jmax-gsa
left a comment
There was a problem hiding this comment.
Reviewed running locally, with desktop browser, simulated mobile (using desktop chrome dev tools) and actual mobile.
LGTM.
AShukla-GSA
force-pushed
the
abrad-lg-15436-new-choose-id-screen
branch
2 times, most recently
from
a0bead9 to
a3092fe
Compare
amirbey
reviewed
Mar 10, 2025
amirbey
reviewed
Mar 10, 2025
amirbey
reviewed
Mar 10, 2025
amirbey
reviewed
Mar 10, 2025
amirbey
reviewed
Mar 10, 2025
amirbey
reviewed
Mar 10, 2025
amirbey
reviewed
Mar 10, 2025
changelog: Upcoming Features, Doc Auth, add a choose your id screen for passports
AShukla-GSA
force-pushed
the
abrad-lg-15436-new-choose-id-screen
branch
from
963d083 to
8c8f5e6
Compare
amirbey
reviewed
Mar 10, 2025
amirbey
reviewed
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15436
🛠 Summary of changes
Created a new "Choose your id" screen for doc auth for a user to be able to select between Drivers License and Passport on the desktop and mobile(non hybrid-handoff) flow.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
doc_auth_passports_enabled: true👀 Screenshots