Skip to content

LG-15558 Permanently enable pending in person password reset feature#11957

Merged
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-15558
Mar 10, 2025
Merged

LG-15558 Permanently enable pending in person password reset feature#11957
shanechesnutt-ft merged 1 commit intomainfrom
sc/LG-15558

Conversation

@shanechesnutt-ft
Copy link
Contributor

@shanechesnutt-ft shanechesnutt-ft commented Mar 6, 2025 •
edited by eileen-nava
Loading

🎫 Ticket

Link to the relevant ticket:
LG-15558

🛠 Summary of changes

Permanently enable the pending in person password reset feature

📜 Testing Plan

Scenario: When pending in-person password reset is enabled and User uses personal key

  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the ready to verify page.
  • Logout
  • Reset the password of the user.
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Ensure user is prompted for personal key entry
  • Enter in user's personal key
  • Ensure user is navigated to the ready to verify page

Scenario: When pending in-person password reset is enabled and User does not use personal key

  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the ready to verify page.
  • Logout
  • Reset the password of the user.
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Ensure user is prompted for personal key entry
  • Continue without a personal key
  • Ensure user is navigated to the welcome page
  • Ensure enrollment is cancelled
  • Ensure user can complete in-person verification flow

Scenario: Fraud review in-person enrollment and user password resets with personal key

  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the ready ssn page.
  • Mark the threat metrics as review on the ready ssn page.
  • Submit the ssn form.
  • Continue the ID-IPP flow reaching the ready to verify page.
  • Run the GetUspsProofingResultsJob
# To manually run the job in the rails console run the following:
job = GetUspsProofingResultsJob.new
job.perform(Time.zone.now)
  • Ensure the enrollment is updated to have in_fraud_review status.
  • Ensure user is navigated to the LG-99 screen.
  • Logout
  • Reset the password of the user.
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Ensure user is prompted for personal key entry
  • Enter in user's personal key
  • Ensure user is navigated to the LG-99 screen

Scenario: Fraud review in-person enrollment and user password resets without personal key

  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the ready ssn page.
  • Mark the threat metrics as review on the ready ssn page.
  • Submit the ssn form.
  • Continue the ID-IPP flow reaching the ready to verify page.
  • Run the GetUspsProofingResultsJob
# To manually run the job in the rails console run the following:
job = GetUspsProofingResultsJob.new
job.perform(Time.zone.now)
  • Ensure the enrollment is updated to have in_fraud_review status.
  • Ensure user is navigated to the LG-99 screen.
  • Logout
  • Reset the password of the user.
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Ensure user is prompted for personal key entry
  • Continue without a personal key
  • Ensure user is navigated to the welcome page
  • Click Continue on welcome page
  • Ensure enrollment is cancelled

@shanechesnutt-ft shanechesnutt-ft marked this pull request as ready for review March 7, 2025 20:12
eileen-nava
eileen-nava reviewed Mar 7, 2025
View reviewed changes
app/views/user_mailer/reset_password_instructions.html.erb Outdated
Copy link
Contributor

@eileen-nava eileen-nava Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really glad we're able to remove this now! :)

app/forms/reset_password_form.rb Outdated
Copy link
Contributor

@eileen-nava eileen-nava Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code and started testing scenarios today. Things generally looked good, except for the last step.
Ensure user is navigated to the ready to verify page
I was navigated to the account page when I logged back in. 🫤 I am unsure why.
I will look at this more on Monday.

Copy link
Contributor

@eileen-nava eileen-nava Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shanechesnutt-ft and I looked at this Monday. I was navigated to the ready to verify page when I logged back in through the Sinatra OIDC Sample app and selected the Identity Verified service level. (When I was navigated to the account page, I had logged in directly through idp and no service level was specified.) As a result, I am satisfied that the flow worked as expected.

@eileen-nava eileen-nava self-requested a review March 10, 2025 17:45
eileen-nava
eileen-nava approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@eileen-nava eileen-nava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried all four scenarios and they all work. The code looks good. Approved!

gina-yamada
gina-yamada reviewed Mar 10, 2025
View reviewed changes
gina-yamada
gina-yamada reviewed Mar 10, 2025
View reviewed changes
gina-yamada
gina-yamada reviewed Mar 10, 2025
View reviewed changes
@gina-yamada
Copy link
Contributor

gina-yamada commented Mar 10, 2025 •
edited
Loading

Gina's Notes for the 📜 Testing Plan:

Scenario: When pending in-person password reset is enabled and User uses personal key

  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the ready to verify page.
  • Logout
  • Reset the password of the user.
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Ensure user is prompted for personal key entry
  • Enter in user's personal key
  • Ensure user is navigated to the ready to verify page

Scenario: When pending in-person password reset is enabled and User does not use personal key

  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the ready to verify page.
  • Logout
  • Reset the password of the user.
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Ensure user is prompted for personal key entry
  • Continue without a personal key
  • Ensure user is navigated to the welcome page
  • Ensure enrollment is cancelled
  • Ensure user can complete in-person verification flow

Scenario: Fraud review in-person enrollment and user password resets with personal key

  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the ready ssn page.
  • Mark the threat metrics as review on the ready ssn page.
  • Submit the ssn form.
  • Continue the ID-IPP flow reaching the ready to verify page.
  • Run the GetUspsProofingResultsJob
  • # To manually run the job in the rails console run the following:
job = GetUspsProofingResultsJob.new
job.perform(Time.zone.now)
  • Ensure the enrollment is updated to have in_fraud_review status.
  • Ensure user is navigated to the LG-99 screen.
  • Logout
  • Reset the password of the user.
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Ensure user is prompted for personal key entry
  • Enter in user's personal key
  • Ensure user is navigated to the LG-99 screen

Scenario: Fraud review in-person enrollment and user password resets without personal key

  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Create a new account
  • Complete the ID-IPP flow reaching the ready ssn page.
  • Mark the threat metrics as review on the ready ssn page.
  • Submit the ssn form.
  • Continue the ID-IPP flow reaching the ready to verify page.
  • Run the GetUspsProofingResultsJob
# To manually run the job in the rails console run the following:
job = GetUspsProofingResultsJob.new
job.perform(Time.zone.now)
  • Ensure the enrollment is updated to have in_fraud_review status.
  • Ensure user is navigated to the LG-99 screen.
  • Logout
  • Reset the password of the user.
  • Login through the oidc sinatra application selecting the Identity Verified level of service.
  • Ensure user is prompted for personal key entry
  • Continue without a personal key
  • Ensure user is navigated to the welcome page
  • Click Continue on welcome page
  • Ensure enrollment is cancelled

@shanechesnutt-ft
LG-15558 Permanently enable pending in person password reset feature
696c4b5 
changelog: Internal, In-person Proofing, Permanently enable the pending in person password reset feature
@gina-yamada gina-yamada self-requested a review March 10, 2025 21:03
gina-yamada
gina-yamada approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@gina-yamada gina-yamada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Shane!!! This is awesome - epic is complete!!! Kudos on a job well done 🚀 🚀

@shanechesnutt-ft shanechesnutt-ft merged commit 5520d7a into main Mar 10, 2025
2 checks passed
@shanechesnutt-ft shanechesnutt-ft deleted the sc/LG-15558 branch March 10, 2025 21:12
@solipet solipet mentioned this pull request Mar 11, 2025
Merged
@mitchellhenke mitchellhenke mentioned this pull request May 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WilliamBirdsall WilliamBirdsall Awaiting requested review from WilliamBirdsall

2 more reviewers

@eileen-nava eileen-nava eileen-nava approved these changes

@gina-yamada gina-yamada gina-yamada approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shanechesnutt-ft @gina-yamada @eileen-nava