Skip to content

Lg-15755 do not display previous empty design for selfie capture#11931

Merged
AShukla-GSA merged 6 commits intomainfrom
lg-15755-do-not-display-previous-empty-design-for-selfie-capture
Mar 4, 2025
Merged

Lg-15755 do not display previous empty design for selfie capture#11931
AShukla-GSA merged 6 commits intomainfrom
lg-15755-do-not-display-previous-empty-design-for-selfie-capture

Conversation

@AShukla-GSA
Copy link
Contributor

@AShukla-GSA AShukla-GSA commented Feb 28, 2025

🎫 Ticket

Link to the relevant ticket:
LG-15755

🛠 Summary of changes

Utilized immediatelyBeginCapture to remove step where user clicks take photo and sees empty selfie state design (and needs to click again) before sdk opens.
Tested on local machine with phone using Mobile Local Dev

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Step 1 - Configure application.yml to use 'lexsis_nexis' w Prod credentials since we are going to be testing failed doc auth flow also. Retrieve credentials using aws-vault commands

doc_auth_selfie_capture_enabled: true
domain_name: :3000
mailer_domain_name: :3000
enable_load_testing_mode: true
doc_auth_vendor: 'lexisnexis'
doc_auth_vendor_default: 'lexis_nexis'
lexisnexis_base_url:
lexisnexis_hmac_auth_enabled: true
lexisnexis_trueid_account_id:
lexisnexis_trueid_username:
lexisnexis_trueid_password:
lexisnexis_trueid_liveness_cropping_workflow:
lexisnexis_trueid_liveness_nocropping_workflow:
lexisnexis_trueid_noliveness_cropping_workflow:
lexisnexis_trueid_noliveness_nocropping_workflow:
lexisnexis_trueid_timeout: '60'

  • Step 2 - Setup local machine w branch Mobile Local Dev
  • Step 3 - Go through Doc Auth with selfie on phone (main thing is that doc capture is on your phone so you can start on your local machine and use telephony to get a link to put on your phone)
  • Step 4 - Once on selfie capture, click the close button on the top right and ensure that empty state design is not show
  • Step 5 - Fail doc auth (Take a empty selfie does it for me)
  • Step 6 - Once at the fail rate limit page click try again
  • Step 7 - Ensure you are brought to a review step page and not have the selfie capture open up immediately as described in this ticket

👀 Screenshots

Video of Walkthrough

@amirbey
Copy link
Contributor

amirbey commented Feb 28, 2025

@AShukla-GSA ... as per this thread it seems that immediatelyBeginCapture is no longer needed and can be removed 🤔

@theabrad can you weigh in here as your recent change was to set immediatelyBeginCapture='false' for a 🐛 fix

@AShukla-GSA AShukla-GSA force-pushed the lg-15755-do-not-display-previous-empty-design-for-selfie-capture branch from 59c6806 to 16a279e Compare February 28, 2025 16:41
@amirbey
Copy link
Contributor

amirbey commented Mar 3, 2025

after following the steps, the selfie capture worked as expected. @AShukla-GSA ... were you able to recreate the failing scenario?

@AShukla-GSA
Copy link
Contributor Author

after following the steps, the selfie capture worked as expected. @AShukla-GSA ... were you able to recreate the failing scenario?

Yes, the video should show me going back to the review step to test the fail scenario where the sdk is automatically opened when the user enteres the review issues page (no longer present). This was fixed in https://cm-jira.usa.gov/browse/LG-14948 . The current solution also fixes this problem while removing the need for immediatelyBeginCapture

@amirbey amirbey self-requested a review March 4, 2025 21:44
Copy link
Contributor

@amirbey amirbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ...works as expected ... blue box no longer appears on initial selfie submission page

@AShukla-GSA AShukla-GSA force-pushed the lg-15755-do-not-display-previous-empty-design-for-selfie-capture branch from 78d28f4 to c841c24 Compare March 4, 2025 22:17
@AShukla-GSA AShukla-GSA merged commit 0f594b2 into main Mar 4, 2025
2 checks passed
@AShukla-GSA AShukla-GSA deleted the lg-15755-do-not-display-previous-empty-design-for-selfie-capture branch March 4, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants