Skip to content

Lg-15755 do not display previous empty design for selfie capture #11931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AShukla-GSA merged 6 commits into from
Mar 4, 2025
Merged

Lg-15755 do not display previous empty design for selfie capture #11931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a5ad157
changelog: Bug Fixes, selfie capture, do not display previous empty s…
AShukla-GSA Feb 27, 2025
c228165
Updating specs
AShukla-GSA Feb 28, 2025
ea375d4
Cleaning up logic removing immediatelyBeginCapture
AShukla-GSA Feb 28, 2025
94fe6c6
Adding review step logic
AShukla-GSA Feb 28, 2025
2ebfe78
fixing tests
AShukla-GSA Feb 28, 2025
c841c24
Tested review step with removed immediatelyBeginCapture logic
AShukla-GSA Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/javascript/packages/document-capture/components/acuant-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,10 @@ interface AcuantCaptureProps {
* Determine whether the selfie help text shoule be shown.
*/
showSelfieHelp: () => void;
/**
* Whether user is on the failed submission review step
*/
isReviewStep?: boolean;
}

/**
Expand Down Expand Up @@ -313,6 +317,7 @@ function AcuantCapture(
errorMessage,
name,
showSelfieHelp,
isReviewStep,
}: AcuantCaptureProps,
ref: Ref<HTMLInputElement | null>,
) {
Expand All @@ -327,7 +332,7 @@ function AcuantCapture(
} = useContext(AcuantContext);
const { isMockClient } = useContext(UploadContext);
const { trackEvent } = useContext(AnalyticsContext);
const { isSelfieCaptureEnabled, immediatelyBeginCapture } = useContext(SelfieCaptureContext);
const { isSelfieCaptureEnabled } = useContext(SelfieCaptureContext);
const fullScreenRef = useRef<FullScreenRefHandle>(null);
const inputRef = useRef<HTMLInputElement>(null);
const isForceUploading = useRef(false);
Expand All @@ -350,7 +355,7 @@ function AcuantCapture(
const isBackOfId = name === 'back';
useLogCameraInfo({ isBackOfId, hasStartedCropping });
const [isCapturingEnvironment, setIsCapturingEnvironment] = useState(
selfieCapture && immediatelyBeginCapture,
selfieCapture && !isReviewStep,
Comment thread
AShukla-GSA marked this conversation as resolved.
);

const {
Expand Down
1 change: 1 addition & 0 deletions app/javascript/packages/document-capture/components/document-side-acuant-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ function DocumentSideAcuantCapture({
className={className}
allowUpload={isUploadAllowed}
showSelfieHelp={showSelfieHelp}
isReviewStep={isReviewStep}
/>
);
}
Expand Down
5 changes: 0 additions & 5 deletions app/javascript/packages/document-capture/context/selfie-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,12 @@ interface SelfieCaptureProps {
* the capture component.
*/
showHelpInitially: boolean;
/**
* Specify whether we should try to capture using Acuant immediately
*/
immediatelyBeginCapture: boolean;
}

const SelfieCaptureContext = createContext<SelfieCaptureProps>({
isSelfieCaptureEnabled: false,
isSelfieDesktopTestMode: false,
showHelpInitially: true,
immediatelyBeginCapture: false,
});

SelfieCaptureContext.displayName = 'SelfieCaptureContext';
Expand Down
1 change: 0 additions & 1 deletion app/javascript/packs/document-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ render(
isSelfieCaptureEnabled: getSelfieCaptureEnabled(),
isSelfieDesktopTestMode: String(docAuthSelfieDesktopTestMode) === 'true',
showHelpInitially: true,
immediatelyBeginCapture: false,
}}
>
<FailedCaptureAttemptsContextProvider
Expand Down
7 changes: 0 additions & 7 deletions spec/javascript/packages/document-capture/components/document-side-acuant-capture-spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ describe('DocumentSideAcuantCapture', () => {
isSelfieCaptureEnabled: false,
isSelfieDesktopTestMode: false,
showHelpInitially: false,
immediatelyBeginCapture: false,
}}
>
<DocumentSideAcuantCapture {...DEFAULT_PROPS} side="front" />
Expand All @@ -50,7 +49,6 @@ describe('DocumentSideAcuantCapture', () => {
isSelfieCaptureEnabled: false,
isSelfieDesktopTestMode: true,
showHelpInitially: false,
immediatelyBeginCapture: false,
}}
>
<DocumentSideAcuantCapture {...DEFAULT_PROPS} side="front" />
Expand All @@ -77,7 +75,6 @@ describe('DocumentSideAcuantCapture', () => {
isSelfieCaptureEnabled: false,
isSelfieDesktopTestMode: false,
showHelpInitially: false,
immediatelyBeginCapture: false,
}}
>
<DocumentSideAcuantCapture {...DEFAULT_PROPS} side="front" />
Expand All @@ -100,7 +97,6 @@ describe('DocumentSideAcuantCapture', () => {
isSelfieCaptureEnabled: false,
isSelfieDesktopTestMode: true,
showHelpInitially: false,
immediatelyBeginCapture: false,
}}
>
<DocumentSideAcuantCapture {...DEFAULT_PROPS} side="front" />
Expand All @@ -127,7 +123,6 @@ describe('DocumentSideAcuantCapture', () => {
isSelfieCaptureEnabled: true,
isSelfieDesktopTestMode: false,
showHelpInitially: false,
immediatelyBeginCapture: false,
}}
>
<DocumentSideAcuantCapture {...DEFAULT_PROPS} side="front" />
Expand Down Expand Up @@ -156,7 +151,6 @@ describe('DocumentSideAcuantCapture', () => {
isSelfieCaptureEnabled: true,
isSelfieDesktopTestMode: true,
showHelpInitially: false,
immediatelyBeginCapture: false,
}}
>
<DocumentSideAcuantCapture {...DEFAULT_PROPS} side="front" />
Expand Down Expand Up @@ -193,7 +187,6 @@ describe('DocumentSideAcuantCapture', () => {
isSelfieCaptureEnabled: true,
isSelfieDesktopTestMode: true,
showHelpInitially: false,
immediatelyBeginCapture: false,
}}
>
<DocumentSideAcuantCapture {...DEFAULT_PROPS} side="front" />
Expand Down
1 change: 0 additions & 1 deletion spec/javascript/packages/document-capture/components/documents-step-spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ describe('document-capture/components/documents-step', () => {
isSelfieCaptureEnabled: true,
isSelfieDesktopTestMode: false,
showHelpInitially: true,
immediatelyBeginCapture: true,
}}
>
<DocumentsStep
Expand Down
2 changes: 0 additions & 2 deletions spec/javascript/packages/document-capture/components/selfie-step-spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ describe('document-capture/components/selfie-step', () => {
isSelfieCaptureEnabled: false,
isSelfieDesktopTestMode: false,
showHelpInitially: false,
immediatelyBeginCapture: false,
}}
>
<SelfieStep
Expand Down Expand Up @@ -76,7 +75,6 @@ describe('document-capture/components/selfie-step', () => {
isSelfieCaptureEnabled: false,
isSelfieDesktopTestMode: false,
showHelpInitially: false,
immediatelyBeginCapture: false,
}}
>
<SelfieStep
Expand Down
1 change: 0 additions & 1 deletion spec/javascript/packages/document-capture/context/selfie-capture-spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ describe('document-capture/context/selfie-capture', () => {
'isSelfieCaptureEnabled',
'isSelfieDesktopTestMode',
'showHelpInitially',
'immediatelyBeginCapture',
]);
expect(result.current.isSelfieCaptureEnabled).to.be.a('boolean');
});
Expand Down