Skip to content

LG-14948 Try again opens selfie capture camera instead of redo doc auth page. #11661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theabrad merged 4 commits into from
Dec 18, 2024
Merged

LG-14948 Try again opens selfie capture camera instead of redo doc auth page. #11661

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
596e3b2
set immediaelyBeginCapture to false in context
theabrad Dec 17, 2024
c667986
add changelog
theabrad Dec 17, 2024
28a9b1b
remove immediatelyBeginCapture from selfie context
theabrad Dec 18, 2024
6abaad9
Revert "remove immediatelyBeginCapture from selfie context"
theabrad Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/packs/document-capture.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ render(
isSelfieCaptureEnabled: getSelfieCaptureEnabled(),
isSelfieDesktopTestMode: String(docAuthSelfieDesktopTestMode) === 'true',
showHelpInitially: true,
immediatelyBeginCapture: true,
immediatelyBeginCapture: false,
Copy link
Copy Markdown
Contributor

@aduth aduth Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only place we had been passing immediatelyBeginCapture ? Can we remove it altogether?

Copy link
Copy Markdown
Contributor Author

@theabrad theabrad Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks like we don't need it. Had to confirm with the team before i outright removed it. Will do.

Copy link
Copy Markdown
Contributor Author

@theabrad theabrad Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing we actually need immediatelyBeginCapture it might be in the acuant docs somewhere

Copy link
Copy Markdown
Contributor

@aduth aduth Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any references to that term in Acuant's source code. What were the issues you were bumping into?

}}
>
<FailedCaptureAttemptsContextProvider
Expand Down