LG-14948 Try again opens selfie capture camera instead of redo doc auth page.#11661
LG-14948 Try again opens selfie capture camera instead of redo doc auth page.#11661
Conversation
changelog: Bug Fixes, Doc Auth, Fix try again button opening up Selfie SDK
theabrad
force-pushed
the
abrad-lg-14948-try-again-bug
branch
from
c276085 to
c667986
Compare
| isSelfieDesktopTestMode: String(docAuthSelfieDesktopTestMode) === 'true', | ||
| showHelpInitially: true, | ||
| immediatelyBeginCapture: true, | ||
| immediatelyBeginCapture: false, |
There was a problem hiding this comment.
Is this the only place we had been passing immediatelyBeginCapture ? Can we remove it altogether?
There was a problem hiding this comment.
Yeah looks like we don't need it. Had to confirm with the team before i outright removed it. Will do.
There was a problem hiding this comment.
After testing we actually need immediatelyBeginCapture it might be in the acuant docs somewhere
There was a problem hiding this comment.
I don't see any references to that term in Acuant's source code. What were the issues you were bumping into?
|
@theabrad @amirbey Could one of you respond to the question at #11661 (comment) ? I don't see that we're ever setting this to anything other than |
|
👋🏿 @aduth - @theabrad initial attempt at removing the field created a behavior change ... due to timeliness, we moved forward with the working version. i've chatted with @theabrad and he will revisit this for a potential follow up PR; however, if we you are still encountering hiccups, @theabrad can you create a ticket to dig into it deeper to clean this up? |
3 participants
🎫 Ticket
Link to the relevant ticket:
LG-14948
🛠 Summary of changes
Fixed a bug where if a user fail's doc auth and hits "Try again online" it immediatly opens up the selfie camera.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.