Merged
Conversation
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-1
branch
from
d21aa15 to
e4cf87b
Compare
n1zyy
reviewed
Dec 6, 2024
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-1
branch
3 times, most recently
from
3f8c0d5 to
24def64
Compare
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-1
branch
3 times, most recently
from
8a3cb94 to
8b232aa
Compare
Contributor
|
can you rebase this to pick up fixes for the reviewapps cluster to be less sad? |
- Change to idv_please_call to indicate it is used by idv generally - Keep in_person_please_call as an alias on the theory that we need it for 1 deploy [skip changelog]
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-1
branch
from
8b232aa to
092612f
Compare
This was referenced Dec 18, 2024
aduth
reviewed
Dec 18, 2024
|
|
||
| RSpec.describe UserMailerPreview do | ||
| it_behaves_like 'a mailer preview' | ||
| it_behaves_like 'a mailer preview', preview_methods_that_can_be_missing: [:in_person_please_call] |
Contributor
There was a problem hiding this comment.
Is this meant to be temporary until we're fully moved over to the new name?
eileen-nava
approved these changes
Dec 18, 2024
| end | ||
| end | ||
|
|
||
| alias_method :in_person_please_call, :idv_please_call |
| user_mailer.email_deleted.help_html: If you did not want to delete this email address, please visit the %{app_name_html} %{help_link_html} or %{contact_link_html}. | ||
| user_mailer.email_deleted.subject: Email address deleted | ||
| user_mailer.help_link_text: Help Center | ||
| user_mailer.idv_please_call.body.contact_message_html: Call <strong>%{contact_number}</strong> and provide them with the error code <strong>%{support_code}</strong>. |
n1zyy
approved these changes
Dec 18, 2024
matthinz
added a commit
that referenced
this pull request
Jan 14, 2025
This was added to support changing the name of a template in #11604 and is no longer needed. [skip changelog]
matthinz
added a commit
that referenced
this pull request
Jan 14, 2025
This was added to support changing the name of a template in #11604 and is no longer needed. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is the first of three PRs, which will be spread across deploys. The next one is #11662, then #11664.
🎫 Ticket
Link to the relevant ticket:
LG-15000
🛠 Summary of changes
We want to update the remote flow to send the "Please call" email. Since it will be the same email the IPP flow currently sends, we're going to rename it to be more generic:
idv_please_callrather thanin_person_please_call.This PR is step one of the process:
idv_please_callmethod to the mailerin_person_please_callas an alias to that method (so we don't break)A subsequent PR will actually add the email to the remote flow and update the in person flow to use the new name.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Go through IdV, selecting the in-person proofing route (make sure you are wicked so that you are flagged by ThreatMetrix)
Once you have your barcode, go to the IPP enrollment list and approve yourself
Verify that the "Please call" email sends as expected