Closed
Conversation
- Change to idv_please_call to indicate it is used by idv generally - Keep in_person_please_call as an alias on the theory that we need it for 1 deploy [skip changelog]
I was having some trouble working with this, so I reworked it a little and added param docs
This is the exact same email, content-wise, just with a new name to reflect the fact that it is used throughout idv. [skip changelog]
Many clients won't display inline images referenced by URL for privacy reasons.
This has been renamed to idv_please_call. [skip changelog]
Contributor
Author
|
whoops, wrong base. closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is 3 of 3. It can't be merged until #11604 and #11662 are in production)
🎫 Ticket
Link to the relevant ticket:
LG-15000
🛠 Summary of changes
#11604 added a new
idv_please_callemail, which is identical toin_person_please_call.#11662 started sending that email from other parts of IDV and updated the in-person code to send
idv_please_callinstead ofin_person_please_callThis PR removes references to
in_person_please_call.