LG-15000: Send "Please call" email from other parts of IDV#11662
Merged
LG-15000: Send "Please call" email from other parts of IDV#11662
Conversation
This was referenced Dec 18, 2024
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-2
branch
2 times, most recently
from
6360574 to
10eecd3
Compare
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-2
branch
from
10eecd3 to
51cc5a3
Compare
Base automatically changed from
matthinz/15000-idv-please-call-part-1
to
main
December 18, 2024 18:25
- Slightly improve error output - Capture behavior in a dedicated spec [skip changelog]
Assert that a certain email was not sent.
These specs weren't actually testing the thing we thought they were, since the text_part of the email did not contain HTML.
This is the exact same email, content-wise, just with a new name to reflect the fact that it is used throughout idv. [skip changelog]
matthinz
force-pushed
the
matthinz/15000-idv-please-call-part-2
branch
from
51cc5a3 to
c50cb70
Compare
Many clients won't display inline images referenced by URL for privacy reasons.
n1zyy
approved these changes
Dec 18, 2024
Contributor
n1zyy
left a comment
n1zyy
left a comment
There was a problem hiding this comment.
I'm liking the idea of breaking these into smaller PRs. 👏
Comment on lines
+129
to
+133
| return if result.extra[:pending_in_person_enrollment] | ||
|
|
||
| return if !result.extra[:fraud_check_failed] | ||
|
|
||
| return if !FeatureManagement.proofing_device_profiling_decisioning_enabled? |
Contributor
There was a problem hiding this comment.
I actually prefer what you have, but I feel like this would more typically be written like:
if result.extra[:pending_in_person_enrollment] ||
!result.extra[:fraud_check_failed] ||
!FeatureManagement.proofing_device_profiling_decisioning_enabled?
returnBut I like the idea of normalizing simpler lines. 👏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-15000
🛠 Summary of changes
Updates the non-IPP IDV flows to send the "Please Call" email
📜 Testing Plan
Phone verification
GPO