[WIP] LG-15000: Send "please call" email for all remote idv flows#11596
[WIP] LG-15000: Send "please call" email for all remote idv flows#11596
Conversation
app/mailers/user_mailer.rb
Outdated
There was a problem hiding this comment.
** is there to support backwards compat with in_person_please_call, can be cleaned up later
app/mailers/user_mailer.rb
Outdated
There was a problem hiding this comment.
This alias can be cleaned up after deploy
There was a problem hiding this comment.
There's a minor 50/50 state risk here--if the 50/50 state persists longer than the deliver_later delay (1 hour), it's possible that an old server could pick up the job and call idv_please_call, which won't exist. However:
- I'm only 99% sure that's how
deliver_laterworks here (i.e. that it re-calls the mailer method later on) - A 50/50 state lasting that long shouldn't happen.
I can remove this and do it in a separate deploy if folks want.
There was a problem hiding this comment.
Just confirming that deliver_later does work this way: https://github.com/rails/rails/blob/17a5ae138ad032ecc372be5e509ef0d15711b22f/actionmailer/lib/action_mailer/message_delivery.rb#L151-L152
There was a problem hiding this comment.
I'm trying to wrap my head around this one. Is there any danger if we discover and issue and need to revert and go from new back to old?
There was a problem hiding this comment.
That is a good callout. I hadn't considered reverting. I think this ends up looking a lot like adding a new job: deliver_later schedules a job that invokes a method on the mailer. If the mailer the job has when it runs does not have the method defined, it will fail.
So I think this will be two PRs / deploys:
- Add new method with IPP variant as an alias
- Start calling it for remote unsupervised + update IPP to call it as well, remove alias
- Change to idv_please_call to indicate it is used by idv generally - Keep in_person_please_call as an alias on the theory that we need it for 1 deploy
There is a minor 50/50 risk here if the 50/50 state lasts an hour or more, but that is very unlikely to happen.
…h_password This is useful to callers
matthinz
force-pushed
the
matthinz/15000-idv-please-call
branch
from
8c0601f to
3e492e8
Compare
|
Gonna split this across a couple PRs / deploys. First one is #11604 |
2 participants
🎫 Ticket
Link to the relevant ticket:
LG-15000