Merged
Conversation
…d` event (#11153) The `idv_doc_auth_verify_polling_wait_visited` gets logged when a polling event occurs on the verify info step. This event does not have any extra attributes that it needs to log. As a result we left off the extra arguments when adding it. Leaving off the extra arguments led to an issue with the `AnalyticsEventsEnhancer`. This adds attributes to the events that are prefixed with `idv_` when they are called. A result of this was a `ArgumentError` for this event since it did not have the extra arguments for these attributes. [skip changelog]
* LG-14220: Standardize and simplify content for consent screen changelog: User-Facing Improvements, Consent Screen, Standardize and simplify content for consent screen * Move strong tag from strings to Ruby code See: #11147 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Fix spec assertion for content --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* LG-14028 | Model DMV maintenance windows in code Model known maintenance windows in code, so that we can set alerts to not fire if they're unreachable during a maintenance window. changelog: Internal, Alerting, Model DMV maintenance windows in code
* disallow socure webhooks in prod and staging hosted envs [skip changelog] * happy linting * use FF for enabling socure_webhook * add check or render not found to socure webhook controller * happy linting * remove route reloading from spec
* temp commit * edit downloader * fed email domain * fix * changelog: Upcoming Features, Authentication, Piv filtering via domains * rubocop fix * use fed email check * fix email address * fed email presenter spec * set up piv cac selection presenter * add file to gitlab ci and setup * change to is fed email * update specs and sample files * address failing spec * remove comment * rename fed email domains spec * add feature flag * change user * use store for config * fix specs errors * sign in spec fix * remove is predicate * refactor to do db instead of reading a file * rubocop * remove downloader and just use a rake task * edit domainsg * remove downloader * edit rake task * remove unneeded config * edit email domain * fix schema * add additional fed email specs * change name * move piv cac recommended to separate spec for ease of readibility * fix rubocop * fix specs * fix specs to use false and true * address comments * remove line * make it simple assignment * update application yaml default * update rake and application yml default * update schema * include default loading of default domain values * address comments * fix merge conflict * update application config * fix schema
* changelog: Upcoming Features, Partner account, Select email to share with partner * add select email form, build out show and create actions in controller * add feature flag * add additional email if have only 1 * add styles to make display match design better * update translations * fix typo in zh * updated completion show spec * add spec for select_email/show view * add spec for select email controller * fix duplicate key entry * fix missing key * adds email_address_id column to Identities table to track selected email address for sp * add SAML, rename sp_email session key, improve syntax * add checking for selected sp email to authentication on existing account * fix lint errors and bug when adding sp for the first time * add in missing email_address_id * include expectation of email_address_id value * fix app_name error in yml * mising translated app_name * add missing token to view * fix test assertion * clean up text syntax * revise test assertion * be more explicit about a fallback email to get the login id * add sign_in test where an alternate email is selected * add SAML example for switching email * authorization_controller update session syntax * add feature flags * remove stray comment * rename form to build_ * added association to identity model and updated methods that use email_address_id * refactor email_address_id method * make sure listed emails are confirmed * adds validation if email belongs to user * utilize StatusPageComponent * add spec to check email ownership * fix broken merge item and lint error * remove unneeded block markup * bind the multiple emails conditional in an elsif * leverage id instead of email string, clarify how form is validating success * add test at form class to confirm validation, fix id-based test changes and bug introduced at mutliple_emails? * reduce conditional return and fix html formatting * make email_id naming clearer * created separate translation for Email not found error text * remove lint faux pas * remove updating last-sign in upon form submit. rename some variables for consistency. * improve identity querying * check for email id value before trying to find an email address * Add specs for expected behavior after deleting email * markup changes to form page * verify completion at select email cont. account for deleting email that relates to identity, remove no longer needed method in session controller * add needs completion state to controller * change content class to grid-col-fill * add test to attribute assertion, show selected email at completions view * add a logout and explicit login instructions * test change masks problem, reverted * account for deleted or missing email by id * add test for deleted email * update tests to include selected_email_id * add test to account for deleted email * clean up queries add signup before_action test, fix typo, add :nullify * fix variable availability * optimize queries to reduce db load, fixes due to uncovered test failures from last commit, add test coverage for nil email id * take out rescue condition * re-add rescue cases for last_email methods * revise conditional to detect multiple confirmed email addresses * remove unneeded function * add markup to fix button width * remove unnecessary db call at id link * fix some queries, change session to user_session * reset test and select if multiple emails * revise completion show tests * add test cases where select email feature is disabled * correct lint errors * remove unused method and correct for consistent nil-safe * fix email-identity association * email_address_id set at consent but if nil does not change for already consented user * remove commented * change test * remove required email_attribute_id from expectations * ensure selected email is passed to SP * rebase and normalize yaml * remove old migration * replace direct DB call with relationship --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
…ount state (#11149) * Update USPS job to nil out enrollment timestamp * added new specs to check profile on get usps job * fix linter errors * changelog: Bug Fixes, In-Person proofing, Update profile.in_person_verification_pending_at timestamp to nil when the enrollment gets cancelled in the get_usps_proofing_results_job * Rename specs, add addi check to deact asst profile * delete breakpoint * Rename profile method to catch enrollment updates * Update failing specs to use renamed profile method * Add pending profile to in_person_enrollment factory pending trait * Co-authored-by: Shane Chesnutt <shane.chesnutt@gsa.gov> --------- Co-authored-by: Shane Chesnutt <shane.chesnutt@gsa.gov>
Fix CI failure on main. [skip changelog]
* LG-14095: set up A/B testing for Socure This sets up a new A/B test to allow management of the distribution of doc_auth requests between LexisNexis TrueID and Socure. There is an already existing A/B test for swapping out doc_auth vendors, DOC_AUTH_VENDOR, but that tests parameters are integrated with the current code base and is really set up for TrueID vs Acuant, two very similar vendors. Given that the Socure integration will be significantly different, I chose to start a new test, and expect that in time it will replace the preceding one. [skip changelog] * lints and specs * Take over the DOC_AUTH_VENDOR a/b test for the Socure integration * make the lexis_nexis bucket both default and explicit
* fix: package.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-WEBPACK-7840298 * Update yarn.lock * Add changelog changelog: Internal, Dependencies, Update dependency to resolve security advisory --------- Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
mdiarra3
approved these changes
Aug 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features