Allow for extra arguments to idv_doc_auth_verify_polling_wait_visited event#11153
Merged
Allow for extra arguments to idv_doc_auth_verify_polling_wait_visited event#11153
idv_doc_auth_verify_polling_wait_visited event#11153Conversation
…d` event The `idv_doc_auth_verify_polling_wait_visited` gets logged when a polling event occurs on the verify info step. This event does not have any extra attributes that it needs to log. As a result we left off the extra arguments when adding it. Leaving off the extra arguments led to an issue with the `AnalyticsEventsEnhancer`. This adds attributes to the events that are prefixed with `idv_` when they are called. A result of this was a `ArgumentError` for this event since it did not have the extra arguments for these attributes. [skip changelog]
zachmargolis
approved these changes
Aug 27, 2024
jmhooper
added a commit
that referenced
this pull request
Aug 27, 2024
…d` event (#11153) The `idv_doc_auth_verify_polling_wait_visited` gets logged when a polling event occurs on the verify info step. This event does not have any extra attributes that it needs to log. As a result we left off the extra arguments when adding it. Leaving off the extra arguments led to an issue with the `AnalyticsEventsEnhancer`. This adds attributes to the events that are prefixed with `idv_` when they are called. A result of this was a `ArgumentError` for this event since it did not have the extra arguments for these attributes. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Aug 27, 2024
* Revert "Merge pull request #11152 from 18F/stages/rc-2024-08-27-revert" This reverts commit 90d418c, reversing changes made to a951867. * Allow for extra arguments to `idv_doc_auth_verify_polling_wait_visited` event (#11153) The `idv_doc_auth_verify_polling_wait_visited` gets logged when a polling event occurs on the verify info step. This event does not have any extra attributes that it needs to log. As a result we left off the extra arguments when adding it. Leaving off the extra arguments led to an issue with the `AnalyticsEventsEnhancer`. This adds attributes to the events that are prefixed with `idv_` when they are called. A result of this was a `ArgumentError` for this event since it did not have the extra arguments for these attributes. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
idv_doc_auth_verify_polling_wait_visitedgets logged when a polling event occurs on the verify info step. This event does not have any extra attributes that it needs to log. As a result we left off the extra arguments when adding it.Leaving off the extra arguments led to an issue with the
AnalyticsEventsEnhancer. This adds attributes to the events that are prefixed withidv_when they are called. A result of this was aArgumentErrorfor this event since it did not have the extra arguments for these attributes.