LG-13355: filter piv upsell

[mdiarra3]

🎫 Ticket

Link to the relevant ticket:
LG-13355

🛠 Summary of changes

This leverages using the Fed domain list to ensure we are only prompting users with Fed emails to add PIV or .mil users.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Locally you can either download the full fed domain path by running ruby lib/fed_email_domain_downloader.rb to download the file locally. Move that file from tmp folder to fed_domain_emails folder. Or use the sample fed_email_domain sample file in the folder.
• Set fed_domain_file_path to the fed_email_domain.txt and set use_fed_domain_file to true
• Create an account with .mil or a valid .gov email domain,
• Be directed to add a piv for valid domains or .mil. Ensure that when using an invalid domain you are not prompted for Emails.

[aduth]

Can you rebase to resolve merge conflicts? I'll plan to give this a closer look shortly.

[zachmargolis]

WDYT of naming this to indicate it has side effects?

Suggested change

	def default_federal_domains
	def set_up_default_federal_domains!

[aduth]

Works well in testing. Left a few non-blocking comments, but LGTM otherwise 👍

[aduth]

This is probably fine since we're only dealing with about 1400 entries, but I'd wonder if this should work a little more like the disposable emails task using insert_all. I think upsert_all could be an option too if we wanted to gracefully handle duplicates. I think the "find" element here is kinda wasted since we don't care to do anything with the result, so we could also just insert and rescue and discard on a ActiveRecord::RecordNotUnique exception.

If this was a bigger file, I'd also suggest using CSV.foreach instead of CSV.parse + Array#each, since it'd process row-by-row instead of loading the whole thing into memory first.

[aduth]

Suggested change

	# rake "fed_email_domains:load_to_db"
	# rake "federal_email_domains:load_to_db"

[aduth]

Noting that this will cause an error if #11082 is merged before this. We could address the issue by only overriding where it's different from default.