Skip to content

LG-14220: Standardize and simplify content for consent screen#11147

Merged
aduth merged 3 commits intomainfrom
aduth-lg-14220-consent-content
Aug 27, 2024
Merged

LG-14220: Standardize and simplify content for consent screen#11147
aduth merged 3 commits intomainfrom
aduth-lg-14220-consent-content

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Aug 26, 2024

🎫 Ticket

LG-14220

🛠 Summary of changes

Updates content logic for the consent screen to be simplified and standardized across IAL1 and IdV consent.

📜 Testing Plan

  1. Have the IdP and sample application running simultaneously
  2. Go to http://localhost:9292
  3. (Optional) Set "Level of Service" to "Identity-verified"
  4. Click "Sign in"
  5. Proceed to sign in
  6. (If not prompted to consent, visit http://localhost:3000/account/connected_accounts , "Disconnect" on the listed applications, and start over)
  7. When prompted to consent, observe consistent language "We’ll share this information with %{sp}:"
  8. Simulate yearly re-consent by applying diff:
diff --git a/app/presenters/completions_presenter.rb b/app/presenters/completions_presenter.rb
index 911246f83f..28e8641515 100644
--- a/app/presenters/completions_presenter.rb
+++ b/app/presenters/completions_presenter.rb
@@ -111,2 +111,3 @@ class CompletionsPresenter
   def consent_has_expired?
+    return true
     completion_context == :consent_expired
  1. Refresh page
  2. Observe same content as before, but with leading sentence "You must consent each year to share your information with %{sp}."

👀 Screenshots

State Before After
IAL1 before-ial1-en after-ial1-en
IAL1 Re-Consent before-ial1-reconsent-en after-ial1-reconsent-en
IdV before-ial2-en after-ial2-en
IdV Re-Consent before-ial2-reconsent-en after-ial2-reconsent-en

changelog: User-Facing Improvements, Consent Screen, Standardize and simplify content for consent screen
@aduth aduth requested a review from a team August 26, 2024 18:13
See: #11147 (comment)

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
@aduth aduth merged commit 5b0822d into main Aug 27, 2024
@aduth aduth deleted the aduth-lg-14220-consent-content branch August 27, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants