Skip to content

Remove unused methods #11000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Jul 29, 2024
Merged

Remove unused methods #11000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/models/email_address.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ def confirmed?
confirmed_at.present?
end

def stale_email_fingerprint?
Pii::Fingerprinter.stale?(email, email_fingerprint)
Copy link
Copy Markdown
Contributor

@aduth aduth Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stale? method might now be unused after this method is removed?

Copy link
Copy Markdown
Contributor Author

@mitchellhenke mitchellhenke Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pii::Fingerprinter.stale? is used elsewhere: https://github.com/18F/identity-idp/blob/e1b0db1c81eba880abb901c50b1885bb678ad95d/app/services/pii/cacher.rb#L61

Copy link
Copy Markdown
Contributor

@aduth aduth Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I missed that one.

Okeydoke 👍

end

Comment on lines -26 to -29
Copy link
Copy Markdown
Contributor Author

@mitchellhenke mitchellhenke Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was no longer used after #7800

def confirmation_period_expired?
expiration_time = confirmation_sent_at +
IdentityConfig.store.add_email_link_valid_for_hours.hours
Expand Down
4 changes: 0 additions & 4 deletions app/services/marketing_site.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,6 @@ def self.help_url
URI.join(BASE_URL, locale_segment, 'help/').to_s
end

def self.security_url
URI.join(BASE_URL, locale_segment, 'security/').to_s
end
Comment on lines -63 to -65
Copy link
Copy Markdown
Contributor Author

@mitchellhenke mitchellhenke Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was no longer used after #8508 and the URL is no longer correct either (login.gov/security now redirects to login.gov/policy)


def self.accessibility_statement_url
URI.join(BASE_URL, locale_segment, 'accessibility/').to_s
end
Expand Down