Conversation
aduth
reviewed
May 31, 2023
aduth
reviewed
May 31, 2023
changelog: User-Facing Improvements, Review step, updating content on idv review / password reentry step
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
aduth
approved these changes
Jun 2, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Couple comments, but LGTM 👍
|
|
||
| def address_verification_method | ||
| user_session.dig('idv', 'address_verification_mechanism') | ||
| user_session.with_indifferent_access.dig('idv', 'address_verification_mechanism') |
Contributor
There was a problem hiding this comment.
How does this change relate to the ticket?
Contributor
Author
There was a problem hiding this comment.
Controller tests won't work because an idv_session is mapped as a symbol rather than a string. I'm not sure why it was specified as a string in the first place, but new tests of the address_verification_mechanism being set will not pass. I thought indifferent access would rock the boat the least
| end | ||
|
|
||
| def new | ||
| @applicant = idv_session.applicant |
Contributor
There was a problem hiding this comment.
I think we can also remove the assign in the spec:
identity-idp/spec/views/idv/review/new.html.erb_spec.rb
Lines 14 to 24 in e7e88a2
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9871
👀 Screenshots
Verify by Phone Case
French:
Spanish:
English:
Verify by Mail Case
French:
Spanish:
English: