Merged
Conversation
…on (#10918) * LG-13477: Fix reprompt for PIV after reauthentication changelog: Bug Fixes, PIV Enrollment, Fix reprompt when reauthenticating to add PIV after sign-in * Delete stored_location when redirecting for PIV setup after sign-in Because we were considering the PIV session value first, we weren't clearing stored_location from the session, and therefore the user would be confusingly redirected back to PIV setup screen after they'd already seen it
changelog: Internal, Reporting, Ensure parameter correctness
* changelog: Internal, doc-capture, refactored step code in doc capture
…10965) * Log new_device with email and password authentication event (#10957) changelog: Internal, Analytics, Log new_device with email and password authentication event * Handle unauthenticated user from new_device helper * Stub warden authenticated? value in stubbed sign-in * Use Devise sign_out for handling lockout Avoids mixed states, more consistent abstraction use * Revert to original success-based logging Should behave more predictably after 06ad70b * Revert unnecessary changes to stub_sign_in
* add doc_auth_result to in_person_enrollments table We want to track doc auth results (unknown, failed, attention) on a user's in-person enrollment * store doc_auth_result in idv_session Co-authored-by: Doug Price <douglas.price@gsa.gov> * add doc_auth_result to ipp enrollment * add doc_auth_result to analytics events * add doc_auth_result to DocumentCaptureSession * doc_auth_result into documentcapturesession part 2 * passing the doc_auth_result via the DocumentCaptureSession model * added test for doc_auth_result in enrollment * api_image_upload_form test for failed doc_auth_response * track analytics for ipp doc_auth_result after finishing ipp * add changelog changelog: Internal, IdV, Add doc_auth_result to in_person enrollments table * lint * fix specs * db schema fix * allow doc_auth_result to be stored in standard and hybrid flow * small fixup * revert hybrid user test to what it was before * add in_person_proofing_result and doc_auth_result to the analytics event --------- Co-authored-by: Doug Price <douglas.price@gsa.gov>
* feat: bypass secondary id check for enhanced ipp * feat: update tests for reusability * changelog: Upcoming Features, Enhanced In-person proofing, Bypass secondary id check for EIPP * feat: add new IAL2 fixtures * feat: add guard clause for eipp under unsupported secondary id check
* Avoid unnecessary seconds conversion before to_i changelog: Internal, Performance, Avoid unnecessary seconds conversion before to_i * Replace Duration#to_i with #in_seconds More clearly communicates the expressed desire for value in seconds
* Fixed broken link to help center. The help center also has a new redirect, so that anyone using the old bad link will end up at the right place. changelog: Bug Fixes,Help Links,Fixed a broken link on the document capture page
amirbey
requested review from
aduth,
gina-yamada,
jmhooper,
mitchellhenke and
zachmargolis
and removed request for
gina-yamada and
zachmargolis
aduth
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Internal
Upcoming Features