Skip to content

Fixed broken link to help center.#10968

Merged
jmax-gsa merged 6 commits intomainfrom
jmax/LG-13945-fix-broken-link-on-doc-capture
Jul 24, 2024
Merged

Fixed broken link to help center.#10968
jmax-gsa merged 6 commits intomainfrom
jmax/LG-13945-fix-broken-link-on-doc-capture

Conversation

@jmax-gsa
Copy link
Contributor

@jmax-gsa jmax-gsa commented Jul 19, 2024

🎫 Ticket

Link to the relevant ticket:
LG-13945

🛠 Summary of changes

Fixed a broken link on the document capture page. We were pointing them to a non-existent help center page.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Bring up the server, create an account, and enter IdV
  • Use the attached YAML file to force a failure when uploading your ID images
  • Click on the 'Learn more about accepted IDs' link, and verify that you are taken to a help center article, not to a 404 error page.

Yaml file for ID upload

failed_alerts:
  - name: Document Classification
    result: Attention

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Upload Your ID

Upload_your_ID

Error Page

Error_page

Help Center

Help_Center

changelog: Bug Fixes,Help Links,Fixed a broken link on the document capture page
Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the invalid (now unused) entry from the HELP_CENTER_ARTICLES allowlist as well?

verify-your-identity/accepted-state-issued-identification

Pulled the offending link out of an allow list.

Co-authored by: Andrew Duthie <andrew.duthie@gsa.gov>
@jmax-gsa
Copy link
Contributor Author

Can we remove the invalid (now unused) entry from the HELP_CENTER_ARTICLES allowlist as well?

verify-your-identity/accepted-state-issued-identification

Done; thank you.

@jmax-gsa jmax-gsa marked this pull request as ready for review July 19, 2024 18:30
@jmax-gsa jmax-gsa requested review from a team and theabrad and removed request for a team July 19, 2024 18:31
manage-your-account/personal-key
trouble-signing-in/face-or-touch-unlock
verify-your-identity/accepted-identification-documents
verify-your-identity/accepted-state-issued-identification
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we consider adding a redirect in the help center to catch this? or was it never working in the first place

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had brought it up in the related Slack discussion and I think we should, but I don't know that that was captured in this ticket. @jmax-gsa do you know if it's going to be addressed here, or is there a separate ticket for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know; I'll bring the question up at standup and either do it as part of this, or drop a pointer to the other ticket if there is one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per conversation w/ May during standup, I'll add the redirect. See her comment on the ticket.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirecet added in GSA-TTS/identity-site#1305

@jmax-gsa jmax-gsa merged commit 4eaeff4 into main Jul 24, 2024
@jmax-gsa jmax-gsa deleted the jmax/LG-13945-fix-broken-link-on-doc-capture branch July 24, 2024 16:47
mitchellhenke pushed a commit that referenced this pull request Jul 31, 2024
* Fixed broken link to help center.

The help center also has a new redirect, so that anyone using the old bad link will end up at the right place.

changelog: Bug Fixes,Help Links,Fixed a broken link on the document capture page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants