Log new_device with email and password authentication event (redo)#10965
Merged
Log new_device with email and password authentication event (redo)#10965
Conversation
changelog: Internal, Analytics, Log new_device with email and password authentication event
Contributor
Author
|
Reverting to draft to make some revisions based on a pairing session (see Slack discussion). |
Avoids mixed states, more consistent abstraction use
Should behave more predictably after 06ad70b
mitchellhenke
approved these changes
Jul 23, 2024
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
…10965) * Log new_device with email and password authentication event (#10957) changelog: Internal, Analytics, Log new_device with email and password authentication event * Handle unauthenticated user from new_device helper * Stub warden authenticated? value in stubbed sign-in * Use Devise sign_out for handling lockout Avoids mixed states, more consistent abstraction use * Revert to original success-based logging Should behave more predictably after 06ad70b * Revert unnecessary changes to stub_sign_in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Unreverts changes originally introduced in #10957, with fix to avoid errors resulting from an unauthenticated Warden user.
The original changes were reverted in #10963
📜 Testing Plan
Repeat Testing Plan from #10957
Verify tests pass.