LG-13627 Add doc auth result to in_person enrollments#10950
Merged
Conversation
We want to track doc auth results (unknown, failed, attention) on a user's in-person enrollment
Co-authored-by: Doug Price <douglas.price@gsa.gov>
changelog: Internal, IdV, Add doc_auth_result to in_person enrollments table
amirbey
reviewed
Jul 18, 2024
amirbey
reviewed
Jul 22, 2024
amirbey
approved these changes
Jul 22, 2024
Comment on lines
+94
to
+95
| attributes[:in_person_proofing_status] = last_enrollment.status | ||
| attributes[:doc_auth_result] = last_enrollment.doc_auth_result |
Contributor
There was a problem hiding this comment.
it'd be hepful to add in_person_proofing_status and doc_auth_result to user_registration_complete method in analytics_events.rb ?
amirbey
reviewed
Jul 22, 2024
Comment on lines
+92
to
+93
| if current_user.in_person_enrollments.any? | ||
| last_enrollment = current_user.in_person_enrollments.last |
Contributor
There was a problem hiding this comment.
Suggested change
| if current_user.in_person_enrollments.any? | |
| last_enrollment = current_user.in_person_enrollments.last | |
| if (last_enrollment = current_user.in_person_enrollments.last) |
mitchellhenke
pushed a commit
that referenced
this pull request
Jul 31, 2024
* add doc_auth_result to in_person_enrollments table We want to track doc auth results (unknown, failed, attention) on a user's in-person enrollment * store doc_auth_result in idv_session Co-authored-by: Doug Price <douglas.price@gsa.gov> * add doc_auth_result to ipp enrollment * add doc_auth_result to analytics events * add doc_auth_result to DocumentCaptureSession * doc_auth_result into documentcapturesession part 2 * passing the doc_auth_result via the DocumentCaptureSession model * added test for doc_auth_result in enrollment * api_image_upload_form test for failed doc_auth_response * track analytics for ipp doc_auth_result after finishing ipp * add changelog changelog: Internal, IdV, Add doc_auth_result to in_person enrollments table * lint * fix specs * db schema fix * allow doc_auth_result to be stored in standard and hybrid flow * small fixup * revert hybrid user test to what it was before * add in_person_proofing_result and doc_auth_result to the analytics event --------- Co-authored-by: Doug Price <douglas.price@gsa.gov>
Contributor
|
Hi @theabrad, in the future when you submit a PR that affects Joy domain, could you please tag @identity-joy-engineers for a review? It would help us keep track of changes in files that we’re working on. You can also post the PR in the #login-team-joy-eng channel and tag the @login-joy-engineers group, if you want to be sure that someone sees the request promptly. Thanks! 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13627
🛠 Summary of changes
Since we are adding the option for a user to go through In person proofing if they fail doc auth we want to track the doc_auth_result to an in_person enrollment.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
spec/fixtures/ial2_test_credential_back_fail_doc_auth_face_match_errors.ymldoc_auth_result(InPersonEnrollment.last)