Merged
Conversation
* Simplify queries with GpoConfirmationCode relationship changelog: Internal, GpoMail, Query optimization * updated_at -> created_at
* Document parameters for verify proofing results event [skip changelog] * Use dots to separate nested option keys * Apply .compact before logging * Analytics: remove nil args from happy hybrid path * Analytics: remove nil args from happy path * Analytics: Remove nil args from gpo path test * Analytics: Remove nil args from in person test * Analytics: Remove nil args from happy selfie tests
…0864) This commit begins the process of splitting the `Idv::ByMail::RequestLetter` controller into 2 separate controllers: 1. A controller for requesting a letter in the IdV workflow 2. A controller for requesting a new letter after the IdV workflow from the enter-code step This change is being made because the current `Idv::ByMail::RequestLetter` controller is built like an IdV-Step controller but has some hacks to enable it to be visited outside the IdV flow to support resends. These exceptions lead to a number of inconsistencies that risk becoming bugs as we make changes to the GPO flow. This commit makes the first part of the change: Adding the new controller and setting up routes for it. A future change will start directing traffic to the new routes and a further change will remove the old routes. [skip changelog]
* Stub AWS cloudwatch at a lower level to create a failing test for fraud report * Fix fraud report query that was missing "limit 10000" changelog: Internal, Reporting, Fix query error in fraud metrics reporting
* Add unique users across all IAL level to UniqueMonthlyAuthCountsByIaa * Add unique users across all IAL levels to TotalMonthlyAuthCountsWithinIaaWindow * Update unique users in CombinedInvoiceSupplementReportV2 (LG-13703) - remove iaa_ial1_plus_2_unique_users - remove issuer_ial1_plus_2_unique_users - add iaa_unique_users - add issuer_unique_users changelog: Internal, Reporting, Update unique users logic in combined-invoice-supplement-report-v2
* draft rake task to backfill sponsor id in all envs * changelog: Upcoming Features, In-person proofing, backfill sponsor id * finish rake task to backfill sponsor id in all envs * ensure that sponsor id is a string and not an integer
Now that BackgroundProofingJob logs ssn_is_unique, we can pull it out of VerifyInfoConcern. This does move where in the giant analytics blob this is logged, but this shouldn't have a significant impact on anything. changelog: Internal, Analytics, Removes now-redundant ssn_is_unique check
This documentation is now served by the [Internal Handbook itself](https://gitlab.login.gov/lg-public/identity-internal-handbook/-/merge_requests/10), so the IdP no longer needs to provide it. changelog: Internal, Analytics, Remove analytics event route
changelog: Upcoming Features, Aggregated Sign-In Email, Avoid sending new device email after account creation
* Set ensure_complete_logs: false for MfaReport - This report uses an aggregate "stats" query, ensure_complete_logs does not necessarily make sense when the results are pre-aggregated * Use more realistic stubbing in Reporting::DropOffReport specs * Use more realistic stubbing in Reporting::AuthenticationReport specs * Update Protocols report to not use ensure_complete_logs - Each query has some sort of aggregation or deduping, so ensure_complete_logs would not have expected behavior changelog: Internal, Reporting, Fix queries across multiple internal reports
zachmargolis
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal
Upcoming Features