Add a Idv::ByMail::ResendLetterController and associated routes#10864
Merged
Add a Idv::ByMail::ResendLetterController and associated routes#10864
Idv::ByMail::ResendLetterController and associated routes#10864Conversation
This commit begins the process of splitting the `Idv::ByMail::RequestLetter` controller into 2 separate controllers: 1. A controller for requesting a letter in the IdV workflow 2. A controller for requesting a new letter after the IdV workflow from the enter-code step This change is being made because the current `Idv::ByMail::RequestLetter` controller is built like an IdV-Step controller but has some hacks to enable it to be visited outside the IdV flow to support resends. These exceptions lead to a number of inconsistencies that risk becoming bugs as we make changes to the GPO flow. This commit makes the first part of the change: Adding the new controller and setting up routes for it. A future change will start directing traffic to the new routes and a further change will remove the old routes. [skip changelog]
matthinz
approved these changes
Jun 25, 2024
Contributor
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
Will this mean we can ultimately get rid of RequestLetterPresenter?
Contributor
Author
🪦 |
This was referenced Jun 25, 2024
jmhooper
added a commit
that referenced
this pull request
Jun 27, 2024
The `ResendLetterController` was introduced in #10864. It was not used to support the 50/50 state when old instances will not have the route and would 404 if users were linked there. Once the changes in #10864 are fully merged this change can be merged to start linking users to the new `ResendLetterController`. From there the functionality to support resends can be removed from the `RequestLetterController`. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Jun 28, 2024
The `ResendLetterController` was introduced in #10864. It was not used to support the 50/50 state when old instances will not have the route and would 404 if users were linked there. Once the changes in #10864 are fully merged this change can be merged to start linking users to the new `ResendLetterController`. From there the functionality to support resends can be removed from the `RequestLetterController`. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Jul 1, 2024
In #10864 a new controller was introduced to handle resends. In #10865 the controller started being used. Once both of those changes are fully deployed this change can be merged to remove the resend funcitonality from the `RequestLetterController`. This change will make the `RequestLetterController` behave like the rest of the IdV-step controllers. It will no longer be accessible outside of the IdV workflow. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Jul 1, 2024
…10866) In #10864 a new controller was introduced to handle resends. In #10865 the controller started being used. Once both of those changes are fully deployed this change can be merged to remove the resend functionality from the `RequestLetterController`. This change will make the `RequestLetterController` behave like the rest of the IdV-step controllers. It will no longer be accessible outside of the IdV workflow. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit begins the process of splitting the
Idv::ByMail::RequestLettercontroller into 2 separate controllers:This change is being made because the current
Idv::ByMail::RequestLettercontroller is built like an IdV-Step controller but has some hacks to enable it to be visited outside the IdV flow to support resends. These exceptions lead to a number of inconsistencies that risk becoming bugs as we make changes to the GPO flow.This commit makes the first part of the change: Adding the new controller and setting up routes for it. A future change will start directing traffic to the new routes and a further change will remove the old routes.