Fix Cloudwatch query errors in various reports#10875
Merged
zachmargolis merged 12 commits intomainfrom Jun 27, 2024
Merged
Conversation
changelog: Internal, Reporting, Fix query error in fraud metrics reporting
zachmargolis
commented
Jun 26, 2024
lib/reporting/mfa_report.rb
Outdated
Contributor
Author
There was a problem hiding this comment.
the query in this file uses | stats so I think the "split over time and combine" approach is not applicable here
zachmargolis
commented
Jun 26, 2024
lib/reporting/protocols_report.rb
Outdated
Contributor
Author
There was a problem hiding this comment.
the queries in this file uses | stats or | dedup so I think the "split over time and combine" approach is not applicable here
- This report uses an aggregate "stats" query, ensure_complete_logs does not necessarily make sense when the results are pre-aggregated
- Each query has some sort of aggregation or deduping, so ensure_complete_logs would not have expected behavior
changelog: Internal, Reporting, Fix queries across multiple internal reports
zachmargolis
force-pushed
the
margolis-cloudwatch-complete-logs
branch
from
1b3fe58 to
f645e07
Compare
Jeremy1026
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Fix LG99 report Cloudwatch Error #10874 fixes it for a Team Agnes report
This PR fixes that same set of errors for reports from other teams
ensure_complete_logs: falsein a few cases where I think it was not appropriate (such as pre-aggregated queries like| statsor| dedup