LG-13739: Avoid sending new device email after account creation#10877
Merged
LG-13739: Avoid sending new device email after account creation#10877
Conversation
changelog: Upcoming Features, Aggregated Sign-In Email, Avoid sending new device email after account creation
mitchellhenke
approved these changes
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-13739
🛠 Summary of changes
Updates logic of
User#authenticated_device?to consider the device authenticated if it was the one that had created the account. This fixes an issue where the new-device email would be unexpectedly sent the first time the user signs in after creating an account, even if that was the device they'd used to create the account.The issue stems from the fact that we previously relied on
:sign_in_after_2faevent existing for the device, but this event is only created if a user authenticates with 2FA, which doesn't happen during the account creation process.📜 Testing Plan
Before: You'd receive a new device sign-in email
After: You don't receive a new device sign-in email