Conversation
jmhooper
force-pushed
the
jmhooper-use-resend-letter-controller
branch
2 times, most recently
from
f53ed02 to
ed81941
Compare
jmhooper
force-pushed
the
jmhooper-remove-resend-from-the-request-letter-controller
branch
from
bd57f94 to
5db748b
Compare
In #10864 a new controller was introduced to handle resends. In #10865 the controller started being used. Once both of those changes are fully deployed this change can be merged to remove the resend funcitonality from the `RequestLetterController`. This change will make the `RequestLetterController` behave like the rest of the IdV-step controllers. It will no longer be accessible outside of the IdV workflow. [skip changelog]
jmhooper
force-pushed
the
jmhooper-remove-resend-from-the-request-letter-controller
branch
from
8313e06 to
6559adc
Compare
Contributor
Author
|
All of the intermediate changes for this one are merged. This should be ready to merge once I get a review. |
zachmargolis
approved these changes
Jul 1, 2024
jmhooper
deleted the
jmhooper-remove-resend-from-the-request-letter-controller
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10864 a new controller was introduced to handle resends. In #10865 the controller started being used. Once both of those changes are fully deployed this change can be merged to remove the resend funcitonality from the
RequestLetterController.This change will make the
RequestLetterControllerbehave like the rest of the IdV-step controllers. It will no longer be accessible outside of the IdV workflow.