Skip to content

Split up the RequestALetterController into separate controllers for sending and resending#10858

Closed
jmhooper wants to merge 3 commits intomainfrom
jmhooper-resend-letter-controller
Closed

Split up the RequestALetterController into separate controllers for sending and resending#10858
jmhooper wants to merge 3 commits intomainfrom
jmhooper-resend-letter-controller

Conversation

@jmhooper
Copy link
Contributor

This changes reduces some confusion in the IdV flow. It will need to be made in 3 parts:

  1. Adding the new routes with functionality
  2. Directing to the new routes
  3. Tearing down the old routes

This change is here to make sure it all works together while I do the above in separate commits

…ending and resending

This changes reduces some confusion in the IdV flow. It will need to be made in 3 parts:

1. Adding the new routes with functionality
2. Directing to the new routes
3. Tearing down the old routes

This change is here to make sure it all works together while I do the above in separate commits

[skip changelog]
@jmhooper
Copy link
Contributor Author

I meant to open this as a draft. It is not intended to be merged. I'll be opening PRs for the component parts and asking for a review on those once I get this green.

Comment on lines +39 to +46
<%= @applicant[:address1] %>
<br />
<% if @applicant[:address2] %>
<%= @applicant[:address2] %>
<br />
<% end %>
<%= @applicant[:city] %>, <%= @applicant[:state] %> <%= @applicant[:zipcode] %>
<br />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a shared/_address.html partial, looks like we could use it here if we want?

Suggested change
<%= @applicant[:address1] %>
<br />
<% if @applicant[:address2] %>
<%= @applicant[:address2] %>
<br />
<% end %>
<%= @applicant[:city] %>, <%= @applicant[:state] %> <%= @applicant[:zipcode] %>
<br />
<%= render partial: 'shared/address', address: @applicant %>
<br />

or maybe if we want to not pass the whole applicant

Suggested change
<%= @applicant[:address1] %>
<br />
<% if @applicant[:address2] %>
<%= @applicant[:address2] %>
<br />
<% end %>
<%= @applicant[:city] %>, <%= @applicant[:state] %> <%= @applicant[:zipcode] %>
<br />
<%= render partial: 'shared/address', address: @applicant.slice(:address1, :address2, :city, :state, :zipcode) %>
<br />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, yeah that looks like a good change

@jmhooper
Copy link
Contributor Author

@jmhooper jmhooper closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants