Begin using the new ResendLetterController#10865
Merged
Conversation
matthinz
approved these changes
Jun 25, 2024
This was referenced Jun 25, 2024
Base automatically changed from
jmhooper-add-resend-letter-controller-and-routes
to
main
June 25, 2024 18:58
jmhooper
force-pushed
the
jmhooper-use-resend-letter-controller
branch
from
1dbe097 to
f53ed02
Compare
The `ResendLetterController` was introduced in #10864. It was not used to support the 50/50 state when old instances will not have the route and would 404 if users were linked there. Once the changes in #10864 are fully merged this change can be merged to start linking users to the new `ResendLetterController`. From there the functionality to support resends can be removed from the `RequestLetterController`. [skip changelog]
jmhooper
force-pushed
the
jmhooper-use-resend-letter-controller
branch
from
f53ed02 to
ed81941
Compare
Contributor
Author
|
The changes in #10864 have been merged. I just rebased this against the latest main. It can be merged once we confirm that the tests are still 🟢 |
jmhooper
added a commit
that referenced
this pull request
Jul 1, 2024
In #10864 a new controller was introduced to handle resends. In #10865 the controller started being used. Once both of those changes are fully deployed this change can be merged to remove the resend funcitonality from the `RequestLetterController`. This change will make the `RequestLetterController` behave like the rest of the IdV-step controllers. It will no longer be accessible outside of the IdV workflow. [skip changelog]
jmhooper
added a commit
that referenced
this pull request
Jul 1, 2024
…10866) In #10864 a new controller was introduced to handle resends. In #10865 the controller started being used. Once both of those changes are fully deployed this change can be merged to remove the resend functionality from the `RequestLetterController`. This change will make the `RequestLetterController` behave like the rest of the IdV-step controllers. It will no longer be accessible outside of the IdV workflow. [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ResendLetterControllerwas introduced in #10864. It was not used to support the 50/50 state when old instances will not have the route and would 404 if users were linked there.Once the changes in #10864 are fully merged this change can be merged to start linking users to the new
ResendLetterController. From there the functionality to support resends can be removed from theRequestLetterController.