Conversation
mitchellhenke
force-pushed
the
mitchellhenke/translations-cn
branch
from
cbe96cd to
ca2125d
Compare
mitchellhenke
force-pushed
the
mitchellhenke/translations-cn
branch
3 times, most recently
from
cb8ac28 to
addb433
Compare
mitchellhenke
force-pushed
the
mitchellhenke/translations-cn
branch
5 times, most recently
from
11b0ab6 to
7ab2232
Compare
mitchellhenke
force-pushed
the
mitchellhenke/translations-cn
branch
from
7ab2232 to
e07d430
Compare
[skip changelog]
mitchellhenke
force-pushed
the
mitchellhenke/translations-cn
branch
from
e07d430 to
4bec092
Compare
| en: English | ||
| es: Spanish | ||
| fr: French | ||
| zh: Chinese |
There was a problem hiding this comment.
Non-blocking: We usually show the language label in that language, would we expect to do the same here?
There was a problem hiding this comment.
I guess I'm not sure. If you chose Spanish as your email language, but choose English as the display language, I guess it makes sense to display in the more context-specific language?
| en: English | ||
| es: Español | ||
| fr: Français | ||
| zh: Chinese |
There was a problem hiding this comment.
Re: Previous comment, I was thinking of language picker, which is here. The other comment is about email language preference, but same note applies.
There was a problem hiding this comment.
Yes, but I don't think we have that translated yet.
There was a problem hiding this comment.
Circling back here. Chinese needs to be changed to Chinese (Simplified). We should stay consistent with other areas of the IdP and change so that each language is displayed in the language it is describing.
4 participants
🛠 Summary of changes
This PR adds the initial bulk Chinese translations, and adds exceptions to avoid failures on known issues that we will address moving forward. This PR also enables Chinese in dev, test and review app environments.