Update default alert styles to replace "Other" variant#449
Merged
Conversation
nickttng
approved these changes
Jun 6, 2024
Contributor
nickttng
left a comment
nickttng
left a comment
There was a problem hiding this comment.
LGTM. Thanks for looking into this.
nickttng
reviewed
Jun 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates the Alert component styles to eliminate the custom
usa-alert--otherstyles. This is intended to be backwards-compatible, where "Other" is intended to represent a stateless alert banner. This is already styled through USWDS as a slightly different shade of gray, and these changes help remove some confusion and extra code.The concept of an "other" or default variant is already inherent to the idea of a BEM class "Block", so it's redundant to have an explicit class. Technically it was already possible to use these styles with a
<div class="usa-alert">, though it was never documented.📜 Testing Plan
👀 Screenshots