Merged
Conversation
aduth
commented
Apr 25, 2024
Contributor
Author
There was a problem hiding this comment.
I would like to remove all of the files in this folder, but there's a few that are still currently in use:
alerts/success.svg(used by "Success Message" and "Badge" components)alerts/error.svg(used by "Error Message" component)alerts/unphishable.svg(used by "Badge" component)
I'll plan to make these changes separately.
For all except the unphishable icon, I think it's a pretty straight-forward swap to use an equivalent Icon instead.
Two caveats:
- There's not a great equivalent design for unphishable icon.
lockandlock_outlineare pretty close, but they don't have the inverted circle effect that the current icon has. - While Success and Error Message icons are applied in styles and can be done in a backwards-compatible manner, the badge icons are embedded in the actual markup, so this could be a breaking change if downstream projects are referencing the icon assets directly.
- For this reason, it might make sense to keep at least
success.svgandunphishable.svgassets present until the next major version release
- For this reason, it might make sense to keep at least
Contributor
There was a problem hiding this comment.
It makes sense to keep the success.svg and unphishable.svg until we consider the badges more thoroughly.
zachmargolis
approved these changes
Apr 26, 2024
Contributor
Author
This was referenced May 7, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎫 Ticket
Implementation for LG-9877
🛠 Summary of changes
Updates alert banner styling to improve contrast and consistency with USWDS.
📜 Testing Plan
npm start👀 Screenshots