Skip to content

Restore, deprecate custom alert icons#443

Merged
aduth merged 1 commit intomainfrom
aduth-deprecate-icons
May 7, 2024
Merged

Restore, deprecate custom alert icons#443
aduth merged 1 commit intomainfrom
aduth-deprecate-icons

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 7, 2024

🛠 Summary of changes

Restores icons removed in #439, and marks them as deprecated in CHANGELOG.md pending the next major release.

These were removed previously because they were not internally referenced by the design system itself in its own styles, but I discovered that some downstream projects reference them directly (example), so removing them should be considered a breaking change.

📜 Testing Plan

Validate that src/img/alerts files removed in #439 are restored here.

@aduth aduth requested a review from nickttng May 7, 2024 13:12
Copy link
Contributor

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@aduth aduth merged commit d3c6c0d into main May 7, 2024
@aduth aduth deleted the aduth-deprecate-icons branch May 7, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants