Skip to content

Use USWDS icons with badge component#442

Merged
aduth merged 1 commit intomainfrom
aduth-badge-icons
May 7, 2024
Merged

Use USWDS icons with badge component#442
aduth merged 1 commit intomainfrom
aduth-badge-icons

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 7, 2024

🛠 Summary of changes

Updates Badge component to use USWDS icons.

This works toward removing our custom alert icons.

Related: #439, #441

📜 Testing Plan

  1. Run locally as npm start
  2. Go to http://localhost:4000/badges/
  3. Observe badge icons

👀 Screenshots

Before After
before after

Copy link
Contributor

@nickttng nickttng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll create a follow-up ticket to update the Figma library version for this, and the validation messages in #441.

@aduth aduth force-pushed the aduth-badge-icons branch from 547dcd8 to f27b3a5 Compare May 7, 2024 15:48
@aduth
Copy link
Contributor Author

aduth commented May 7, 2024

Visual regression failure is expected due to icon and markup changes:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants