Update Login.gov Design System from v9.3.0 to v9.4.0#11435
Merged
Conversation
changelog: Internal, Dependencies, Update Login.gov Design System from v9.3.0 to v9.4.0
aduth
commented
Oct 31, 2024
| &:first-child { | ||
| padding-left: $alert-icon-optical-padding; | ||
| padding-right: units(1); | ||
| @include u-padding-x(2); |
Contributor
Author
There was a problem hiding this comment.
$alert-icon-optical-padding is no longer available to reference from USWDS. Additionally, we've adjusted the padding on alert icons since 18F/identity-design-system#439, which wasn't yet reflected in these duplicated styles. The net result is a slight increase in padding.
http://localhost:3000/rails/mailers/user_mailer/in_person_ready_to_verify
| Before | After |
|---|---|
 |
 |
mitchellhenke
approved these changes
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates the Login.gov Design System (
@18f/identity-design-system) from v9.3.0 to v9.4.0See changelog: TBD
📜 Testing Plan
yarn installmake run👀 Screenshots
One noticeable difference will be alignment of icons in error message for multi-line field errors.