Conversation
|
I was struggling to get the 404 page to show up in the preview environment. Based on a related Slack comment, I believe Cloud.gov Pages will always try to use the production deployment's 404 page, hence why it's not yet showing up here. Since the plan will be to apply the configuration reverted in 6982fbd in the Cloud.gov Pages Dashboard, merging this as-is won't actually remove any content from the site, but it will add the 404 page so that we can at least confirm it's working in production before applying the new configuration. So effectively, this pull request simply adds a 404 page, but does not affect any other existing content. |
|
The visual regression build failure reflects the change discussed at #333 (comment) . Compare:
|
|
Maybe we need to normalize the intrinsic sizes of those two images. |
In 608fde9, I recreated the reverse logo by taking the original and swapping out all the |
This approach works, and it looks good to me. |
As part of the current effort to deprecate design.login.gov, show a 404 page in place of site contents, so that a user has resources to learn more about Login.gov or receive support.
Allows base_url support
| @@ -0,0 +1,3 @@ | |||
| --- | |||
| layout: 404 | |||
There was a problem hiding this comment.
does the docs dir already go to top level? do we need to add a permalink so that it's in the right place to be a 404 page for CG pages?
| layout: 404 | |
| layout: 404 | |
| permalink: /404.html |
There was a problem hiding this comment.
I think it's fine without? It seems to be available at /404.html already without specifying permalink.
|
Confirmed that the 404 configuration approach works. I did this by adding the following configuration to the Preview Site configuration: To decommission the production site, we'll just add that configuration to the Live Site configuration. † The broken image and styles are somewhat expected, for the same reason as described at #333 (comment) : Cloud.gov Pages 404 pages always use the live site's 404 page, which would include references to root-relative |


As part of the current effort to deprecate design.login.gov, show a 404 page in place of site contents, so that a user has resources to learn more about Login.gov or receive support.
Live preview: https://federalist-2f194a10-945e-4413-be01-46ca6dae5358.sites.pages.cloud.gov/preview/18f/identity-style-guide/aduth-docs-404/404.html
This is derived from the Login.gov main site 404 page: https://www.login.gov/404.html
Next steps:
Revisions to_config.ymlwill not be committed, they are for demonstration only in the preview environment. The plan would be to configure these through Cloud.gov Pages interface18f/identity-idprepository.Draft while I sort out why Cloud.gov Pages doesn't show the 404 page by default.See #333 (comment)