Merged
Conversation
Why? So that it'll continue to work after the main design.login.gov site is decommissioned.
Since it'll be different between preview environments affected by visual regression spec
Contributor
Author
zachmargolis
approved these changes
May 2, 2023
Comment on lines
+13
to
+14
| const REMOTE_HOST = | ||
| 'https://federalist-340d8801-aa16-4df5-ad22-b1e3e731098e.sites.pages.cloud.gov/site/18f/identity-design-system'; |
Contributor
There was a problem hiding this comment.
WDYT of trying to have this do a git checkout main or something instead of continuing to rely on federalist? My expectation is that by shutting down design.login.gov we'd remove everything published?
Contributor
Author
There was a problem hiding this comment.
For the near term, I'm expecting we'll continue to use Federalist to be able to use the branch preview functionality, even if the main https://design.login.gov site will start to show a 404 (which, per #333 (comment), is still going to be hosted by Federalist).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why? So that it'll continue to work after the main design.login.gov site is decommissioned.
Also updates a few other internal references to https://design.login.gov which would break after the site is taken offline.