Conversation
| {% if sidenav %} | ||
| <div class="grid-row grid-gap"> | ||
| <aside class="usa-layout-docs__sidenav desktop:grid-col-3"> | ||
| <aside class="display-none tablet:display-block tablet:grid-col-3"> |
There was a problem hiding this comment.
These changes move away from the internal-ish usa-layout-docs styles, which should have an accessibility benefit by avoiding issues concerning order styles. Instead, the markup is duplicated so that it still appears below content as expected at small screens, but reflecting that in the markup as well.
There was a problem hiding this comment.
What's our timeline for spinning down this site? Should we just start removing content from it so we don't have to maintain it?
There was a problem hiding this comment.
What's our timeline for spinning down this site? Should we just start removing content from it so we don't have to maintain it?
Still nailing down specifics on this. #333 will prep the production site to 404. Once that's in place, I was going to remove many of the non-component content pages, but may want to continue keeping around some of the rest of the documentation for internal development reference, pull request preview links, and visual regression specs. So it'd continue to be useful to have this working, at least for the short term.
| {% if sidenav %} | ||
| <div class="grid-row grid-gap"> | ||
| <aside class="usa-layout-docs__sidenav desktop:grid-col-3"> | ||
| <aside class="display-none tablet:display-block tablet:grid-col-3"> |
There was a problem hiding this comment.
What's our timeline for spinning down this site? Should we just start removing content from it so we don't have to maintain it?
2 participants
Fixes issue where documentation pages with sidebar appear incorrectly stacked. Consistent with changes proposed in #298 (specifically 24ed561), standardize on the "tablet" breakpoint.
This breakage of the documentation site wasn't caught by visual regression specs since the screen size for visual regression specs was set to a size which wouldn't have been affected by this change.