Error-boundary followup (after #4585).#4591
Merged
gnprice merged 2 commits intozulip:masterfrom Apr 5, 2021
Merged
Conversation
Contributor
Author
|
Please also see a note about a widget Sentry provides: #4585 (comment). |
Contributor
Author
|
|
As Greg suggests as a followup to zulip#4585 [1]. [1] zulip#4585 (comment)
gnprice
force-pushed
the
pr-error-boundary-followup-1
branch
from
548826e to
c0aa9e1
Compare
Member
|
Looks good, thanks! Merging.
Hmm, yeah -- the Sentry error ID in particular would be nice. Rather than say more here, I'll start a chat thread 🙂 [edit: here] |
Contributor
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RootErrorBoundary: Separate explanatory text from tappable button.
As Greg suggests as a followup to #4585 [1].
[1] #4585 (comment)