Skip to content

Error-boundary followup (after #4585). #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnprice merged 2 commits into from
Apr 5, 2021
Merged

Error-boundary followup (after #4585). #4591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2257f54
RootErrorBoundary: Separate explanatory text from tappable button.
chrisbobbe Apr 3, 2021
c0aa9e1
RootErrorBoundary [nfc]: Mention examples of lack-of-setup in jsdoc.
chrisbobbe Apr 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/RootErrorBoundary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* @flow strict-local */
import React from 'react';
import { View, Clipboard, TextInput, ScrollView, Button, Platform } from 'react-native';
import { View, Text, Clipboard, TextInput, ScrollView, Button, Platform } from 'react-native';
import Toast from 'react-native-simple-toast';

import * as logging from './utils/logging';
Expand All @@ -27,7 +27,8 @@ type State = $ReadOnly<{|
* from this component itself. It doesn't depend on any external setup
* except Sentry's initialization (without which we'd have no hope of
* reporting the error to Sentry), e.g., from other React components
* in the tree.
* in the tree. N.B., this means things like proper safe-area
* handling, light-dark theming, and translation won't work.
*
* [1] https://reactjs.org/docs/error-boundaries.html#how-about-event-handlers
*/
Expand Down Expand Up @@ -91,8 +92,9 @@ ${error.stack}`;
padding: 50,
}}
>
<Text>Ouch, there was an error.</Text>
<Button
title="Ouch, there's been an error. Tap to copy the stack trace below."
title="Copy details"
// If something in `onPress` fails, we shouldn't get a
// white screen [1]: "Unlike the render method and
// lifecycle methods, the event handlers don’t happen
Expand Down