ZulipMobile: Add and use RootErrorBoundary.#4585
Conversation
|
See screenshots/discussion at #4584 (comment). |
627a902 to
a844200
Compare
|
Hmm, potentially interesting: Sentry provides a ready-to-use component But other than that, I think it'd work, if we wanted to use it. One nice thing, if I pass a function for the |
a844200 to
de70e18
Compare
Though it looks like it might not be too hard to set something like this up manually: getsentry/sentry-react-native#500 |
de70e18 to
9124ca1
Compare
|
Looks good, thanks! Merging. I have one bit of UI feedback that I think is worth doing (naturally we don't want to spend a lot of time on this UI): instead of having a lot of text in the button: a more idiomatic thing to do would be to have some text to say most of that, and then have the button very concisely say what the button itself will do. Like maybe "Copy details". See e.g.: But given that I'd like to ship a beta today with #4588, and it'd be good to include this in that too, that is not something worth blocking on and instead can be a small followup 🙂 |
9124ca1 to
2cc385a
Compare
|
(Also I made a tiny formatting tweak to the output: Component Stack:
-
${because it seemed like empirically there were one too many blank lines in there. My screenshot just above reflects that change.) |
|
Thanks for the review! |
As Greg suggests as a followup to zulip#4585 [1]. [1] zulip#4585 (comment)
As Greg suggests as a followup to zulip#4585 [1]. [1] zulip#4585 (comment)

Fixes: #4584