user: Expand checks in getHaveServerData.#4588
Merged
chrisbobbe merged 1 commit intozulip:masterfrom Apr 2, 2021
Merged
Conversation
The one check we had would be perfectly sufficient in a world where we used a reliable form of storage for keeping data from the server on the device between runs of the app. It does not suffice given our model with redux-persist. This doesn't fix the problem -- that will take something more fundamental -- but it hopefully mitigates the worst consequences. In particular, empirically we already reasonably gracefully handle in the unreads view and the PM-conversations view a situation where either `state.unreads` or `state.pmConversations` refers to streams, subscriptions, or users that we don't have data about: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Android.3A.20White.20screen/near/1151982 Fixes: zulip#4587
gnprice
added
a-multi-org
a-redux
severe: crash
Contributor
|
Thanks, LGTM! Merged. |
This was referenced Apr 23, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one check we had would be perfectly sufficient in a world where
we used a reliable form of storage for keeping data from the server
on the device between runs of the app. It does not suffice given
our model with redux-persist.
This doesn't fix the problem -- that will take something more
fundamental -- but it hopefully mitigates the worst consequences.
In particular, empirically we already reasonably gracefully handle
in the unreads view and the PM-conversations view a situation where
either
state.unreadsorstate.pmConversationsrefers to streams,subscriptions, or users that we don't have data about:
https://chat.zulip.org/#narrow/stream/48-mobile/topic/Android.3A.20White.20screen/near/1151982
Fixes: #4587