chore: remove unused partition spec

[tchow-zlai]

Summary

Checklist

• Added Unit Tests
• Covered by existing CI
• Integration tested
• Documentation update

Summary by CodeRabbit

• Refactor
  • Simplified internal method signatures by removing implicit parameters.
  • Streamlined configuration parsing by removing error handling wrappers, improving processing flow without affecting user experience.

[coderabbitai]

Walkthrough

The update removes the implicit PartitionSpec parameter from two methods in TableDependencies, making these methods require only their explicit arguments. Additionally, import statements are consolidated and reorganized for clarity. The LocalRunner object removes a private helper method for parsing configs and simplifies config parsing by directly mapping over files without error handling. No internal logic or control flow beyond these changes is altered.

Changes

File(s)	Change Summary
api/src/main/scala/ai/chronon/api/planner/TableDependencies.scala	Removed implicit PartitionSpec from method signatures; consolidated and reorganized imports.
api/src/main/scala/ai/chronon/api/planner/LocalRunner.scala	Removed private tryParsingConf method; simplified config parsing by direct mapping without error handling.

Possibly related PRs

• replace partition spec with column #776: Changes implicit parameters from PartitionSpecWithColumn to PartitionSpec in planner classes, related to implicit parameter handling in TableDependencies.
• fix: Ignore label join deps and just use groupBy, leftsource, bootstrap  #891: Refactors internal implementation of fromJoin in TableDependencies while retaining implicit parameter, related to method modifications in the same class.

Suggested reviewers

• varant-zlai
• nikhil-zlai
• piyush-zlai

Poem

Methods once whispered, “spec, please come through,”
Now they stand boldly, with arguments few.
Imports align in a tidy new row,
Simpler signatures, ready to go!
Configs now parse without a catch,
Clean and direct, no errors to match.
Code spring-cleaned, with nothing to fear.
✨🐇✨

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

api/src/main/scala/ai/chronon/api/planner/LocalRunner.scala (1)

42-42: Remove unused implicit variable.

The testPartitionSpec variable is defined but never used, aligning with the PR objective to remove unused partition specs.

-    implicit val testPartitionSpec = PartitionSpec.daily

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 90bb95a and d3b8807.

📒 Files selected for processing (1)

• api/src/main/scala/ai/chronon/api/planner/LocalRunner.scala (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: fetcher_tests
• GitHub Check: groupby_tests
• GitHub Check: streaming_tests
• GitHub Check: analyzer_tests
• GitHub Check: spark_tests
• GitHub Check: batch_tests
• GitHub Check: scala_compile_fmt_fix
• GitHub Check: cloud_gcp_tests
• GitHub Check: cloud_aws_tests
• GitHub Check: online_tests
• GitHub Check: service_commons_tests
• GitHub Check: service_tests
• GitHub Check: flink_tests
• GitHub Check: api_tests
• GitHub Check: aggregator_tests
• GitHub Check: enforce_triggered_workflows

🔇 Additional comments (1)

api/src/main/scala/ai/chronon/api/planner/LocalRunner.scala (1)

25-27: ```shell
#!/bin/bash

inspect fromJsonFile body

sed -n '110,165p' api/src/main/scala/ai/chronon/api/ThriftJsonCodec.scala

check if testPartitionSpec is referenced

rg "testPartitionSpec" -n api/src

</details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->