fix: Ignore label join deps and just use groupBy, leftsource, bootstrap #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant TableDependencies
participant Join
participant GroupBy
participant Source
Caller->>TableDependencies: fromJoin(join)
TableDependencies->>Join: access joinParts, left, bootstrapParts
loop For each joinPart
TableDependencies->>GroupBy: fromGroupBy(joinPart.groupBy)
end
TableDependencies->>Source: fromSource(join.left)
loop For each bootstrapPart
TableDependencies->>Source: fromTable(bootstrapPart)
end
TableDependencies-->>Caller: return all dependencies
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms (15)
🔇 Additional comments (4)
|
tchow-zlai
changed the title
tchow-zlai
requested review from
chewy-zlai,
david-zlai,
nikhil-zlai,
piyush-zlai and
varant-zlai
nikhil-zlai
approved these changes
Jun 24, 2025
piyush-zlai
approved these changes
Jun 24, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
api/src/main/scala/ai/chronon/api/planner/TableDependencies.scala (1)
27-27: Simplify bootstrap parts conversion.The array conversion is unnecessarily complex.
- scala.Option(join.bootstrapParts.toScala.toArray[BootstrapPart]).getOrElse(Array.empty[BootstrapPart]) + Option(join.bootstrapParts).map(_.asScala.toSeq).getOrElse(Seq.empty)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
api/src/main/scala/ai/chronon/api/planner/TableDependencies.scala(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: scala_compile_fmt_fix
- GitHub Check: online_tests
- GitHub Check: cloud_aws_tests
- GitHub Check: api_tests
- GitHub Check: cloud_gcp_tests
- GitHub Check: service_commons_tests
- GitHub Check: service_tests
- GitHub Check: aggregator_tests
- GitHub Check: flink_tests
- GitHub Check: enforce_triggered_workflows
🔇 Additional comments (2)
api/src/main/scala/ai/chronon/api/planner/TableDependencies.scala (2)
7-8: New imports look appropriate.Required for the refactored
fromJoinimplementation.
23-29: Verify the labelParts → joinParts change.The refactor delegates nicely to existing methods, but switching from
join.labelPartstojoin.joinPartscould change behavior significantly.#!/bin/bash # Verify usage of labelParts vs joinParts in the codebase rg -A 3 -B 3 "labelParts|joinParts" --type scala
tchow-zlai
force-pushed
the
tchow/monolith-deps
branch
from
1e7e469 to
91c2bb0
Compare
4 tasks
This was referenced Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Summary by CodeRabbit