Skip to content

chore: remove unused partition spec #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

chore: remove unused partition spec #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90bb95a
chore: remove table dependencies
thomaschow Jun 25, 2025
d3b8807
simplify
thomaschow Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions api/src/main/scala/ai/chronon/api/planner/LocalRunner.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,9 @@ object LocalRunner {
Constants.foldersToIgnore.exists(file.getPath.split("/").contains(_))
}

private def tryParsingConf[T <: TBase[_, _]: Manifest: ClassTag](file: String): Option[T] =
try {
val res = Some(ThriftJsonCodec.fromJsonFile[T](file, check = true))
res
} catch {
case ex: Exception =>
throw new RuntimeException(s"Failed to parse file: $file", ex)
}

def parseConfs[T <: TBase[_, _]: Manifest: ClassTag](confSubfolder: String): Seq[T] = listFiles(confSubfolder)
.filterNot(isIgnorableFile)
.flatMap(tryParsingConf[T])
.toSeq
.map(ThriftJsonCodec.fromJsonFile(_, check = true))

/** To run:
* bazel build //api:planner_deploy.jar
Expand Down
11 changes: 5 additions & 6 deletions api/src/main/scala/ai/chronon/api/planner/TableDependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,20 @@
package ai.chronon.api.planner
import ai.chronon.api
import ai.chronon.api.{Accuracy, BootstrapPart, DataModel, TableDependency, TableInfo, Window}
import ai.chronon.api.Extensions._
import ai.chronon.api.ScalaJavaConversions.IteratorOps
import ai.chronon.api.{Accuracy, DataModel, PartitionSpec, TableDependency, TableInfo, Window}
import ai.chronon.api.ScalaJavaConversions.{IterableOps, IteratorOps}

import scala.collection.JavaConverters._
import ai.chronon.api.ScalaJavaConversions.IterableOps
import ai.chronon.api.BootstrapPart

object TableDependencies {

def fromStagingQuery(stagingQuery: api.StagingQuery)(implicit spec: PartitionSpec): Seq[TableDependency] = {
def fromStagingQuery(stagingQuery: api.StagingQuery): Seq[TableDependency] = {
Option(stagingQuery.tableDependencies)
.map(_.asScala.toSeq)
.getOrElse(Seq.empty)
}

def fromJoin(join: api.Join)(implicit spec: PartitionSpec): Seq[TableDependency] = {
def fromJoin(join: api.Join): Seq[TableDependency] = {
val joinParts = Option(join.joinParts).map(_.iterator().toScala.toArray).getOrElse(Array.empty)
val joinPartDeps = joinParts.flatMap((jp) => fromGroupBy(jp.groupBy))
val leftDep = fromSource(join.left)
Expand Down