gpui: Extract gpui_platform out of gpui - #49277
Merged
Merged
Conversation
cla-bot
Bot
added
the
cla-signed
zed-community-bot
Bot
added
the
staff
Co-authored-by: Eric Holk <eric@zed.dev> Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
osiewicz
pushed a commit
that referenced
this pull request
Feb 19, 2026
After #49277 was merged, all visual tests failed to run with the error "FAILED - render_to_image not implemented for this platform". Release Notes: - N/A
Merged
maxdeviant
added a commit
that referenced
this pull request
Feb 20, 2026
Fix regressions from #49277: - The fusion manifest was not being embedded for Zed.exe, making it non-functional. - The relative path used to load shaders in debug mode was incorrect. Release Notes: - N/A Co-authored-by: Marshall Bowers <git@maxdeviant.com>
huacnlee
added a commit
to longbridge/gpui-component
that referenced
this pull request
Feb 21, 2026
zed-industries/zed#49277 ## Breaking Changes - Removed `PixelsExt` trait, the methods are already in GPUI.
reflectronic
added a commit
that referenced
this pull request
Feb 26, 2026
rtfeldman
pushed a commit
that referenced
this pull request
Feb 27, 2026
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
More fallout from zed-industries#49277. Closes zed-industries#50149. Release Notes: - Fixed remote server failing to launch on Windows.
5 tasks
pull Bot
pushed a commit
to esinanturan/zed
that referenced
this pull request
May 12, 2026
…tries#56322) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#56314 When running `cargo run -p gpui --example hello_world` on a wayland linux machine, the code panics and give the following output: ``` thread 'main' (15645) panicked at crates/gpui_linux/src/linux.rs:55:14: internal error: entered unreachable code note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` and the related code is: https://github.com/zed-industries/zed/blob/c8f09caee42ea4e27991ca55257f6f9c7d7c67d2/crates/gpui_linux/src/linux.rs#L29-L57 `gpui::guess_compositor()` correctly returns `"Wayland"`, but the corresponding match arm is gated behind `#[cfg(feature = "wayland")]` in `gpui_linux`, and that feature is never enabled. During the extract gpui_platform refactor (zed-industries#49277), the `wayland` and `x11` features were added to the `zed` binary's dependency on `gpui_platform`, but were missed in the `[dev-dependencies]` of `gpui/Cargo.toml`, which is what the examples use. This PR adds the missing features to the dev-dependency so that `gpui_platform` propagates them to `gpui_linux` when building examples. Release Notes: - N/A or Added/Fixed/Improved ... Co-authored-by: Kunall Banerjee <hey@kimchiii.space>
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
Fix regressions from zed-industries/zed#49277: - The fusion manifest was not being embedded for Zed.exe, making it non-functional. - The relative path used to load shaders in debug mode was incorrect. Release Notes: - N/A Co-authored-by: Marshall Bowers <git@maxdeviant.com>
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
More fallout from zed-industries/zed#49277. Closes #50149. Release Notes: - Fixed remote server failing to launch on Windows.
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
zed-industries#2874 on steroids Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A --------- Co-authored-by: Eric Holk <eric@zed.dev>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
After zed-industries#49277 was merged, all visual tests failed to run with the error "FAILED - render_to_image not implemented for this platform". Release Notes: - N/A
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
Fix regressions from zed-industries#49277: - The fusion manifest was not being embedded for Zed.exe, making it non-functional. - The relative path used to load shaders in debug mode was incorrect. Release Notes: - N/A Co-authored-by: Marshall Bowers <git@maxdeviant.com>
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
More fallout from zed-industries#49277. Closes zed-industries#50149. Release Notes: - Fixed remote server failing to launch on Windows.
jonx
pushed a commit
to jonx/zed-aros
that referenced
this pull request
Jul 17, 2026
…tries#56322) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#56314 When running `cargo run -p gpui --example hello_world` on a wayland linux machine, the code panics and give the following output: ``` thread 'main' (15645) panicked at crates/gpui_linux/src/linux.rs:55:14: internal error: entered unreachable code note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` and the related code is: https://github.com/zed-industries/zed/blob/c8f09caee42ea4e27991ca55257f6f9c7d7c67d2/crates/gpui_linux/src/linux.rs#L29-L57 `gpui::guess_compositor()` correctly returns `"Wayland"`, but the corresponding match arm is gated behind `#[cfg(feature = "wayland")]` in `gpui_linux`, and that feature is never enabled. During the extract gpui_platform refactor (zed-industries#49277), the `wayland` and `x11` features were added to the `zed` binary's dependency on `gpui_platform`, but were missed in the `[dev-dependencies]` of `gpui/Cargo.toml`, which is what the examples use. This PR adds the missing features to the dev-dependency so that `gpui_platform` propagates them to `gpui_linux` when building examples. Release Notes: - N/A or Added/Fixed/Improved ... Co-authored-by: Kunall Banerjee <hey@kimchiii.space>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
zed-industries#2874 on steroids Before you mark this PR as ready for review, make sure that you have: - [ ] Added a solid test coverage and/or screenshots from doing manual testing - [ ] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) Release Notes: - N/A --------- Co-authored-by: Eric Holk <eric@zed.dev>
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
After zed-industries#49277 was merged, all visual tests failed to run with the error "FAILED - render_to_image not implemented for this platform". Release Notes: - N/A
jolutz
pushed a commit
to jolutz/zed
that referenced
this pull request
Aug 8, 2026
…tries#56322) Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes zed-industries#56314 When running `cargo run -p gpui --example hello_world` on a wayland linux machine, the code panics and give the following output: ``` thread 'main' (15645) panicked at crates/gpui_linux/src/linux.rs:55:14: internal error: entered unreachable code note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` and the related code is: https://github.com/zed-industries/zed/blob/2ce9268169d39cfe3fcd4f4bb27e4c3585bf8847/crates/gpui_linux/src/linux.rs#L29-L57 `gpui::guess_compositor()` correctly returns `"Wayland"`, but the corresponding match arm is gated behind `#[cfg(feature = "wayland")]` in `gpui_linux`, and that feature is never enabled. During the extract gpui_platform refactor (zed-industries#49277), the `wayland` and `x11` features were added to the `zed` binary's dependency on `gpui_platform`, but were missed in the `[dev-dependencies]` of `gpui/Cargo.toml`, which is what the examples use. This PR adds the missing features to the dev-dependency so that `gpui_platform` propagates them to `gpui_linux` when building examples. Release Notes: - N/A or Added/Fixed/Improved ... Co-authored-by: Kunall Banerjee <hey@kimchiii.space>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2874 on steroids
Before you mark this PR as ready for review, make sure that you have:
Release Notes: