gpui: Fix swapped '<' and '>' in guess_ascii for Linux - #49185
gpui: Fix swapped '<' and '>' in guess_ascii for Linux#49185Albab-Hasan wants to merge 1 commit into
guess_ascii for Linux#49185Conversation
the guess_ascii fallback (used for non-latin keyboard layouts) had the shifted characters for comma (keycode 59) and period (keycode 60) swapped. shift+comma should produce '<' and shift+period should produce '>', not the other way around.
cla-bot
Bot
added
the
cla-signed
maxdeviant
changed the title
guess_ascii for Linux
f9004d3 to
4b8a4ec
Compare
|
Looks like #49277 had arrived and fixed this, at least the excerpt in question seems correct: 
Thank you for spotting nonetheless! |
|
@SomeoneToIgnore is there any reason my pr's arent getting reviewed/noticed? should i improve something? |
|
The reviews are our best effort and may drag behind the schedule, unfortunately. This particular one now has conflicts as the entire file was overwritten in the PR I've mentioned above and now the same PR seems to have the codes made rights — so the fix itself was made already. |
|
@SomeoneToIgnore totally get it. love the editor and what you guys are building. thank you guys for your efforts. hopefully ill be able to make meaningful contributions to this project. also if u have some free time i would appreciate it if you could check out this pr. |
|
Sorry, here I have no good context knowledge so I have to defer to someone else's review there. |
|
@SomeoneToIgnore hey, is there any way i can talk to you? I would like to ask a few questions if you dont mind. |
|
In mo profile, I have a contact e-mail and another link, if that helps. Also, we have https://github.com/zed-industries/zed/discussions where others may also chime in and help. |
|
@SomeoneToIgnore can i reach out on telegram if thats okay? |
2 participants
the guess_ascii fallback (used for non-latin keyboard layouts) had the shifted characters for comma (keycode 59) and period (keycode 60) swapped. shift+comma should produce '<' and shift+period should produce '>', not the other way around.
Release Notes: