[Reference POC] CSV/TSV preview (Actual development happens in separate PRs) by HalavicH · Pull Request #44344 · zed-industries/zed

HalavicH · 2025-12-07T17:25:58Z

Hey everyone! 👋

This draft PR introduces an initial CSV preview for Zed — similar to Markdown preview, but for tabular data.

Why I’m proposing this

I often work with CSV/TSV files and found myself missing a native preview/tabular data editor in Zed.
This prototype started as a personal exploration, but it also moves toward a longer-term goal: laying groundwork for database client support inside Zed — the one feature still keeping other IDEs on my machine.

Status

This PR is currently a POC / draft.
I communicate with @Anthony-Eid regarding PR direction and progress.
Some features are incomplete or rough around the edges.
I’m actively iterating in my spare time.
After initial discussion I plan to split this PR in parts based on functionality, and deliver them separately for easier review

Current features

Live CSV preview with automatic refresh
Draggable column resizing (based on the keymap editor’s table component)
CSV parsing with quoted/multiline fields
Variable height rows (requires updates to ui/data_table.rs)
Variable column support (I lift const generics limitation of Table component to allow arbitraray number of columns)
Displaying row identifiers as src line numbers or rows in the table
Sorting by any column (A-Z/Z-A)
Cell selection via mouse/keyboard including multiple selections
Viewport following viewport automatically scrolls up/down on selection
Copy selected as CSV/TSV/Markdown. Non rectangular selections will be padded with empty cells
Inline editing of cells (Press enter, edit in place, enter again to submit)

Demos

Sorting & line numbers + custom column widths:

Select and copy demo:

General side by side view showing source .csv text:

Implementation notes

This prototype reuses existing components (markdown_preview and the keymap editor Table).
The main challenge was const generics: runtime column counts can’t map to compile-time consts, so I removed it in favor of dynamic column definition using newtype which wraps Vec instead of const-generic arrays, which probably will impact performance (didn't measure yet).

It’s functional, and covers my usecase but clearly not elegant — feedback appreciated.

Future roadmap

Column filtering / searching within column
TSV or rather <any-delimiter>SV support
Polishing UI/UX (horizontal scrolling, variable height rows, monospace font)
Moving toward a general table viewer (eventual database client foundation)

Release Notes

Added CSV preview with resizable columns, sorting, and more. Draft PR

zed-industries-bot · 2025-12-07T17:26:30Z

	Warnings
⚠️	This PR is missing release notes. Please add a "Release Notes" section that describes the change: `Release Notes: - Added/Fixed/Improved ...` If your change is not user-facing, you can use "N/A" for the entry: `Release Notes: - N/A`

Generated by 🚫 dangerJS against 3bcf33b

@Anthony-Eid

## Add variable row height mode to data table infrastructure This PR introduces support for variable row heights in the data table component, laying the groundwork for more flexible tabular data rendering in Zed. **Context:** This is the first in a series of infrastructure-focused PRs split out from the [original CSV preview draft PR](#44344). The draft PR remains open as a reference and will be incrementally decomposed into smaller, reviewable pieces like this one. **Details:** - Adds a variable row height mode to the data table, enabling future features that require rows of differing heights (such as CSV preview and, eventually, database table views). - No user-facing changes; this is an internal refactor to support upcoming functionality. **Thanks:** Big thanks to @Anthony-Eid for pairing sessions and guidance on how to best structure and land these changes incrementally. --- Release Notes: - N/A (internal infrastructure change, no user impact)

@Anthony-Eid

## Add variable row height mode to data table infrastructure This PR introduces support for variable row heights in the data table component, laying the groundwork for more flexible tabular data rendering in Zed. **Context:** This is the first in a series of infrastructure-focused PRs split out from the [original CSV preview draft PR](#44344). The draft PR remains open as a reference and will be incrementally decomposed into smaller, reviewable pieces like this one. **Details:** - Adds a variable row height mode to the data table, enabling future features that require rows of differing heights (such as CSV preview and, eventually, database table views). - No user-facing changes; this is an internal refactor to support upcoming functionality. **Thanks:** Big thanks to @Anthony-Eid for pairing sessions and guidance on how to best structure and land these changes incrementally. --- Release Notes: - N/A (internal infrastructure change, no user impact)

jaczanet · 2026-01-08T22:04:13Z

I often work with CSV/TSV files and found myself missing a native preview/tabular data editor in Zed [...] the one feature still keeping other IDEs on my machine.

For whoever will work on the "tabular editor" feature in Zed, I'd like to point out this VS code plugin as inspiration for future work: SQLite Viewer. There's a demo video clearly showing some desirable functionality. 😉

…46341) This PR removes the const generics limitation from the data table component, enabling tables with a dynamic number of columns determined at runtime. **Context:** This is the next infrastructure step split out from the [original CSV preview draft PR](#44344). The draft PR remains open as a reference and will continue to be decomposed into smaller, reviewable pieces. **Details:** - Introduces a `TableRow` newtype to enforce column count invariants at runtime, replacing the previous const generic approach. It's api surface is larger than is currently used, as it's planned to be used in CSV feature itself. - Refactors the data table and all usages (including the keymap editor) to work with runtime column counts. - This change is foundational for supporting CSV preview and other features that require flexible, dynamic tables. - Performance impact has not been formally measured, but there is no noticeable slowdown in practice. --- Release Notes: - N/A (internal infrastructure change, no user impact) --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

@Anthony-Eid

## Add variable row height mode to data table infrastructure This PR introduces support for variable row heights in the data table component, laying the groundwork for more flexible tabular data rendering in Zed. **Context:** This is the first in a series of infrastructure-focused PRs split out from the [original CSV preview draft PR](#44344). The draft PR remains open as a reference and will be incrementally decomposed into smaller, reviewable pieces like this one. **Details:** - Adds a variable row height mode to the data table, enabling future features that require rows of differing heights (such as CSV preview and, eventually, database table views). - No user-facing changes; this is an internal refactor to support upcoming functionality. **Thanks:** Big thanks to @Anthony-Eid for pairing sessions and guidance on how to best structure and land these changes incrementally. --- Release Notes: - N/A (internal infrastructure change, no user impact)

theVedanta · 2026-01-19T23:09:38Z

This is awesome. I would love to see this!
Is there any way I can help?

HalavicH · 2026-01-20T11:38:40Z

This is awesome. I would love to see this! Is there any way I can help?

Hi. Nice to hear.
Not sure about help. I'm currently working on the last infra piece which is needed to start merging the CSV feature itself (piece by piece). It's variable table width, which depends on column width (like a google spreadsheet).

If you're hyped about db client part, and you'd like to do something about it, you can start investigating the laundry list of stuff we need to implement in order to get from "ender db creds" menu to introspecting the db, and seing it's schema similar to file tree :)

mikayla-maki · 2026-02-04T15:06:35Z

Hi, thank you for this PR. Unfortunately, this kind of feature is too extensive and requires too much design support from Zed for us to accept the contribution. I believe we’re working on a new feature proposal process that will make it possible to get dedicated Zed resources, see our github discussion forum for more.

HalavicH · 2026-02-10T12:02:57Z

Hi, thank you for this PR. Unfortunately, this kind of feature is too extensive and requires too much design support from Zed for us to accept the contribution. I believe we’re working on a new feature proposal process that will make it possible to get dedicated Zed resources, see our github discussion forum for more.

Hi. I'm a bit confused about it, since I've been communicating with @Anthony-Eid about this feature, and we have a merge plan (2 infra PRs already merged, 1st PR with actual implementation is in review).

So as I stated in PR description, this PR is just a draft reference, which is not planned to be merged 🙂

## **Description:** **Context:** This PR introduces an initial CSV preview feature for Zed, building upon two previously merged infrastructure PRs: - [#46341](#46341) - Data table dynamic column support (removed const generics) - [#46190](#46190) - Variable row height mode for data tables This implementation is based on the [original draft PR #44344](#44344), which has been carefully decomposed into smaller, reviewable pieces. --- #### **Features Included:** **Core Infrastructure:** - Live CSV parsing with smart debouncing (200ms cooldown) - Performance monitoring with built-in timing metrics (not displayed in UI yet) - Automatic file change detection and re-parsing - Support for quoted fields, multiline cells, and escaped characters **Table Display:** - Variable row height rendering with fallback to uniform mode (switchable via settings) - Draggable column resizing (reusing existing data table infrastructure) - Row identifiers supporting both source line numbers and sequential row numbers - Configurable font rendering (UI font vs monospace) - Tooltips showing full cell content on hover **Interactive Features:** - Column sorting (ascending/descending) with visual indicators **Settings Panel:** - Toggle between variable/uniform row rendering - Font type selection (UI/monospace) - Row identifier type configuration - Debug information display - Multiline cell rendering options --- #### **Features Intentionally Removed for This PR:** To reduce complexity and review scope, the following features were temporarily reverted and will be reintroduced in subsequent PRs: - ❌ Settings pannel with performance metrics overlay - ❌ Cell selection (single, multiple, and range selections) - ❌ Keyboard navigation with arrow keys and selection extension - ❌ Copy functionality supporting CSV, TSV, and Markdown table formats - ❌ Inline cell editing with file persistence - ❌ Viewport following for large datasets - ❌ Column filtering and search capabilities These removals were done via "time-machine" commits that cleanly nuked vertical slices of functionality from the complete implementation. --- **Technical Implementation:** The feature is organized into a dedicated `csv_preview` crate with the following structure: ``` crates/csv_preview/ ├── src/ │ ├── csv_preview.rs # Main view and coordination logic │ ├── parser.rs # CSV parsing and editor integration │ ├── settings.rs # Configuration types and defaults │ ├── table_data_engine.rs # Data transformation logic │ ├── renderer/ # UI rendering modules │ │ ├── preview_view.rs # Main render implementation │ │ ├── render_table.rs # Table component assembly │ │ ├── table_cell.rs # Individual cell rendering │ │ ├── table_header.rs # Header with sorting controls │ │ └── row_identifiers.rs # Line number column │ └── types/ # Core data structures │ ├── table_like_content.rs │ ├── coordinates.rs # Display vs data coordinate systems │ └── table_cell.rs ``` **Key architectural decisions:** - **Dual coordinate system**: Separates data indices from display indices to support sorting/filtering - **Component reuse**: Leverages existing `data_table` infrastructure from the keymap editor --- **Integration:** - Registers `csv::OpenPreview` action (currently without default keybindings) - Follows the same workspace integration pattern as `markdown_preview` and `svg_preview` - Automatically detects `.csv` file extensions - Tab integration with appropriate icons and naming --- **Code Structure Note:** Some code structures, types, and documentation may appear redundant or over-engineered in this initial implementation. This is intentional - the feature was developed as a complete system and then decomposed by functionality rather than being built incrementally. The "extra" infrastructure supports features that were removed for this PR but will be reintroduced in subsequent ones. This approach was chosen over extensive refactoring because: 1. The complete feature took 200+ commits to develop with significant rewrites 2. Clean extraction of vertical slices was more feasible than rebuilding incrementally 3. The end state will utilize all these components, making current "redundancy" temporary I apologize for any inconvenience this may cause during review, but the alternative would have required significant refactoring effort just to make intermediate states "prettier," which seemed counterproductive. --- **Future Work:** This lays the groundwork for upcoming PRs that will reintroduce the removed features: - Cell selection and keyboard navigation - Copy functionality with multiple output formats - Inline editing capabilities with undo/redo - Column filtering and search - TSV and other delimiter support - Improved horizontal scrolling behavior - Settings persistence **Testing:** Includes test fixtures demonstrating multiline cell handling, various column counts, and edge cases. --- **Release Notes:** - N/A This is feature flagged --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

…dustries#48207) ## **Description:** **Context:** This PR introduces an initial CSV preview feature for Zed, building upon two previously merged infrastructure PRs: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support (removed const generics) - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables This implementation is based on the [original draft PR zed-industries#44344](zed-industries#44344), which has been carefully decomposed into smaller, reviewable pieces. --- #### **Features Included:** **Core Infrastructure:** - Live CSV parsing with smart debouncing (200ms cooldown) - Performance monitoring with built-in timing metrics (not displayed in UI yet) - Automatic file change detection and re-parsing - Support for quoted fields, multiline cells, and escaped characters **Table Display:** - Variable row height rendering with fallback to uniform mode (switchable via settings) - Draggable column resizing (reusing existing data table infrastructure) - Row identifiers supporting both source line numbers and sequential row numbers - Configurable font rendering (UI font vs monospace) - Tooltips showing full cell content on hover **Interactive Features:** - Column sorting (ascending/descending) with visual indicators **Settings Panel:** - Toggle between variable/uniform row rendering - Font type selection (UI/monospace) - Row identifier type configuration - Debug information display - Multiline cell rendering options --- #### **Features Intentionally Removed for This PR:** To reduce complexity and review scope, the following features were temporarily reverted and will be reintroduced in subsequent PRs: - ❌ Settings pannel with performance metrics overlay - ❌ Cell selection (single, multiple, and range selections) - ❌ Keyboard navigation with arrow keys and selection extension - ❌ Copy functionality supporting CSV, TSV, and Markdown table formats - ❌ Inline cell editing with file persistence - ❌ Viewport following for large datasets - ❌ Column filtering and search capabilities These removals were done via "time-machine" commits that cleanly nuked vertical slices of functionality from the complete implementation. --- **Technical Implementation:** The feature is organized into a dedicated `csv_preview` crate with the following structure: ``` crates/csv_preview/ ├── src/ │ ├── csv_preview.rs # Main view and coordination logic │ ├── parser.rs # CSV parsing and editor integration │ ├── settings.rs # Configuration types and defaults │ ├── table_data_engine.rs # Data transformation logic │ ├── renderer/ # UI rendering modules │ │ ├── preview_view.rs # Main render implementation │ │ ├── render_table.rs # Table component assembly │ │ ├── table_cell.rs # Individual cell rendering │ │ ├── table_header.rs # Header with sorting controls │ │ └── row_identifiers.rs # Line number column │ └── types/ # Core data structures │ ├── table_like_content.rs │ ├── coordinates.rs # Display vs data coordinate systems │ └── table_cell.rs ``` **Key architectural decisions:** - **Dual coordinate system**: Separates data indices from display indices to support sorting/filtering - **Component reuse**: Leverages existing `data_table` infrastructure from the keymap editor --- **Integration:** - Registers `csv::OpenPreview` action (currently without default keybindings) - Follows the same workspace integration pattern as `markdown_preview` and `svg_preview` - Automatically detects `.csv` file extensions - Tab integration with appropriate icons and naming --- **Code Structure Note:** Some code structures, types, and documentation may appear redundant or over-engineered in this initial implementation. This is intentional - the feature was developed as a complete system and then decomposed by functionality rather than being built incrementally. The "extra" infrastructure supports features that were removed for this PR but will be reintroduced in subsequent ones. This approach was chosen over extensive refactoring because: 1. The complete feature took 200+ commits to develop with significant rewrites 2. Clean extraction of vertical slices was more feasible than rebuilding incrementally 3. The end state will utilize all these components, making current "redundancy" temporary I apologize for any inconvenience this may cause during review, but the alternative would have required significant refactoring effort just to make intermediate states "prettier," which seemed counterproductive. --- **Future Work:** This lays the groundwork for upcoming PRs that will reintroduce the removed features: - Cell selection and keyboard navigation - Copy functionality with multiple output formats - Inline editing capabilities with undo/redo - Column filtering and search - TSV and other delimiter support - Improved horizontal scrolling behavior - Settings persistence **Testing:** Includes test fixtures demonstrating multiline cell handling, various column counts, and edge cases. --- **Release Notes:** - N/A This is feature flagged --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

This PR adds spreadsheet-style independently resizable columns (dragging changes total table width) and fixes scrolling issues in variable list mode. **What changed:** - Adds `ResizableColumnsState` struct for independently resizable columns (spreadsheet-style) - Adds `ColumnWidthConfig::Resizable` variant for spreadsheet mode - Adds `DraggedResizableColumn` drag payload type - Adds `ResizableHeaderInfo` for double-click-to-reset functionality - Adds `render_resize_handles_resizable` function for resize handles rendering - Adds horizontal scroll handle to `TableInteractionState` - Adds `.on_drag_move::<DraggedResizableColumn>` handler to Table for drag resizing **Bug fixes:** - Fixed missing vertical scrollbar in variable list mode - Fixed half-broken scrolling in variable list mode (added .measure_all() to make scrollbar aware of the height of the table) - Moved vertical scrollbar to be pinned at the right side of the pane with table — previously it was attached to the table content and was pushed off-screen when table content was too wide **API addition:** ```rust // New variant added: pub enum ColumnWidthConfig { Static { widths: StaticColumnWidths, table_width: Option<DefiniteLength> }, Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength> }, Resizable(Entity<ResizableColumnsState>), // NEW: spreadsheet-style } ``` **Callers updated:** - csv_preview: Changed from `ColumnWidthConfig::redistributable()` to use new resizable mode - git_graph: Added `resizable_info` parameter **Context:** This is part 3 of a 3-PR series improving data table column width handling: 1. [#51059](#51059) - Extract modules into separate files (mechanical change) 2. [#51120](#51120) - Introduce width config enum for redistributable column widths (API rework) 3. **This PR**: Add independently resizable columns + fix variable list scrolling (new feature + bug fixes) The series builds on previously merged infrastructure: - [#46341](#46341) - Data table dynamic column support - [#46190](#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([#48207](#48207)) This work is based on the [original draft PR #44344](#44344), decomposed into reviewable pieces. ----- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A or Added/Fixed/Improved ... --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

This PR adds spreadsheet-style independently resizable columns (dragging changes total table width) and fixes scrolling issues in variable list mode. **What changed:** - Adds `ResizableColumnsState` struct for independently resizable columns (spreadsheet-style) - Adds `ColumnWidthConfig::Resizable` variant for spreadsheet mode - Adds `DraggedResizableColumn` drag payload type - Adds `ResizableHeaderInfo` for double-click-to-reset functionality - Adds `render_resize_handles_resizable` function for resize handles rendering - Adds horizontal scroll handle to `TableInteractionState` - Adds `.on_drag_move::<DraggedResizableColumn>` handler to Table for drag resizing **Bug fixes:** - Fixed missing vertical scrollbar in variable list mode - Fixed half-broken scrolling in variable list mode (added .measure_all() to make scrollbar aware of the height of the table) - Moved vertical scrollbar to be pinned at the right side of the pane with table — previously it was attached to the table content and was pushed off-screen when table content was too wide **API addition:** ```rust // New variant added: pub enum ColumnWidthConfig { Static { widths: StaticColumnWidths, table_width: Option<DefiniteLength> }, Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength> }, Resizable(Entity<ResizableColumnsState>), // NEW: spreadsheet-style } ``` **Callers updated:** - csv_preview: Changed from `ColumnWidthConfig::redistributable()` to use new resizable mode - git_graph: Added `resizable_info` parameter **Context:** This is part 3 of a 3-PR series improving data table column width handling: 1. [zed-industries#51059](zed-industries#51059) - Extract modules into separate files (mechanical change) 2. [zed-industries#51120](zed-industries#51120) - Introduce width config enum for redistributable column widths (API rework) 3. **This PR**: Add independently resizable columns + fix variable list scrolling (new feature + bug fixes) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) This work is based on the [original draft PR zed-industries#44344](zed-industries#44344), decomposed into reviewable pieces. ----- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A or Added/Fixed/Improved ... --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

@Anthony-Eid

## Add variable row height mode to data table infrastructure This PR introduces support for variable row heights in the data table component, laying the groundwork for more flexible tabular data rendering in Zed. **Context:** This is the first in a series of infrastructure-focused PRs split out from the [original CSV preview draft PR](zed-industries/zed#44344). The draft PR remains open as a reference and will be incrementally decomposed into smaller, reviewable pieces like this one. **Details:** - Adds a variable row height mode to the data table, enabling future features that require rows of differing heights (such as CSV preview and, eventually, database table views). - No user-facing changes; this is an internal refactor to support upcoming functionality. **Thanks:** Big thanks to @Anthony-Eid for pairing sessions and guidance on how to best structure and land these changes incrementally. --- Release Notes: - N/A (internal infrastructure change, no user impact)

…(#46341) This PR removes the const generics limitation from the data table component, enabling tables with a dynamic number of columns determined at runtime. **Context:** This is the next infrastructure step split out from the [original CSV preview draft PR](zed-industries/zed#44344). The draft PR remains open as a reference and will continue to be decomposed into smaller, reviewable pieces. **Details:** - Introduces a `TableRow` newtype to enforce column count invariants at runtime, replacing the previous const generic approach. It's api surface is larger than is currently used, as it's planned to be used in CSV feature itself. - Refactors the data table and all usages (including the keymap editor) to work with runtime column counts. - This change is foundational for supporting CSV preview and other features that require flexible, dynamic tables. - Performance impact has not been formally measured, but there is no noticeable slowdown in practice. --- Release Notes: - N/A (internal infrastructure change, no user impact) --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

## **Description:** **Context:** This PR introduces an initial CSV preview feature for Zed, building upon two previously merged infrastructure PRs: - [#46341](zed-industries/zed#46341) - Data table dynamic column support (removed const generics) - [#46190](zed-industries/zed#46190) - Variable row height mode for data tables This implementation is based on the [original draft PR #44344](zed-industries/zed#44344), which has been carefully decomposed into smaller, reviewable pieces. --- #### **Features Included:** **Core Infrastructure:** - Live CSV parsing with smart debouncing (200ms cooldown) - Performance monitoring with built-in timing metrics (not displayed in UI yet) - Automatic file change detection and re-parsing - Support for quoted fields, multiline cells, and escaped characters **Table Display:** - Variable row height rendering with fallback to uniform mode (switchable via settings) - Draggable column resizing (reusing existing data table infrastructure) - Row identifiers supporting both source line numbers and sequential row numbers - Configurable font rendering (UI font vs monospace) - Tooltips showing full cell content on hover **Interactive Features:** - Column sorting (ascending/descending) with visual indicators **Settings Panel:** - Toggle between variable/uniform row rendering - Font type selection (UI/monospace) - Row identifier type configuration - Debug information display - Multiline cell rendering options --- #### **Features Intentionally Removed for This PR:** To reduce complexity and review scope, the following features were temporarily reverted and will be reintroduced in subsequent PRs: - ❌ Settings pannel with performance metrics overlay - ❌ Cell selection (single, multiple, and range selections) - ❌ Keyboard navigation with arrow keys and selection extension - ❌ Copy functionality supporting CSV, TSV, and Markdown table formats - ❌ Inline cell editing with file persistence - ❌ Viewport following for large datasets - ❌ Column filtering and search capabilities These removals were done via "time-machine" commits that cleanly nuked vertical slices of functionality from the complete implementation. --- **Technical Implementation:** The feature is organized into a dedicated `csv_preview` crate with the following structure: ``` crates/csv_preview/ ├── src/ │ ├── csv_preview.rs # Main view and coordination logic │ ├── parser.rs # CSV parsing and editor integration │ ├── settings.rs # Configuration types and defaults │ ├── table_data_engine.rs # Data transformation logic │ ├── renderer/ # UI rendering modules │ │ ├── preview_view.rs # Main render implementation │ │ ├── render_table.rs # Table component assembly │ │ ├── table_cell.rs # Individual cell rendering │ │ ├── table_header.rs # Header with sorting controls │ │ └── row_identifiers.rs # Line number column │ └── types/ # Core data structures │ ├── table_like_content.rs │ ├── coordinates.rs # Display vs data coordinate systems │ └── table_cell.rs ``` **Key architectural decisions:** - **Dual coordinate system**: Separates data indices from display indices to support sorting/filtering - **Component reuse**: Leverages existing `data_table` infrastructure from the keymap editor --- **Integration:** - Registers `csv::OpenPreview` action (currently without default keybindings) - Follows the same workspace integration pattern as `markdown_preview` and `svg_preview` - Automatically detects `.csv` file extensions - Tab integration with appropriate icons and naming --- **Code Structure Note:** Some code structures, types, and documentation may appear redundant or over-engineered in this initial implementation. This is intentional - the feature was developed as a complete system and then decomposed by functionality rather than being built incrementally. The "extra" infrastructure supports features that were removed for this PR but will be reintroduced in subsequent ones. This approach was chosen over extensive refactoring because: 1. The complete feature took 200+ commits to develop with significant rewrites 2. Clean extraction of vertical slices was more feasible than rebuilding incrementally 3. The end state will utilize all these components, making current "redundancy" temporary I apologize for any inconvenience this may cause during review, but the alternative would have required significant refactoring effort just to make intermediate states "prettier," which seemed counterproductive. --- **Future Work:** This lays the groundwork for upcoming PRs that will reintroduce the removed features: - Cell selection and keyboard navigation - Copy functionality with multiple output formats - Inline editing capabilities with undo/redo - Column filtering and search - TSV and other delimiter support - Improved horizontal scrolling behavior - Settings persistence **Testing:** Includes test fixtures demonstrating multiline cell handling, various column counts, and edge cases. --- **Release Notes:** - N/A This is feature flagged --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

This PR adds spreadsheet-style independently resizable columns (dragging changes total table width) and fixes scrolling issues in variable list mode. **What changed:** - Adds `ResizableColumnsState` struct for independently resizable columns (spreadsheet-style) - Adds `ColumnWidthConfig::Resizable` variant for spreadsheet mode - Adds `DraggedResizableColumn` drag payload type - Adds `ResizableHeaderInfo` for double-click-to-reset functionality - Adds `render_resize_handles_resizable` function for resize handles rendering - Adds horizontal scroll handle to `TableInteractionState` - Adds `.on_drag_move::<DraggedResizableColumn>` handler to Table for drag resizing **Bug fixes:** - Fixed missing vertical scrollbar in variable list mode - Fixed half-broken scrolling in variable list mode (added .measure_all() to make scrollbar aware of the height of the table) - Moved vertical scrollbar to be pinned at the right side of the pane with table — previously it was attached to the table content and was pushed off-screen when table content was too wide **API addition:** ```rust // New variant added: pub enum ColumnWidthConfig { Static { widths: StaticColumnWidths, table_width: Option<DefiniteLength> }, Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength> }, Resizable(Entity<ResizableColumnsState>), // NEW: spreadsheet-style } ``` **Callers updated:** - csv_preview: Changed from `ColumnWidthConfig::redistributable()` to use new resizable mode - git_graph: Added `resizable_info` parameter **Context:** This is part 3 of a 3-PR series improving data table column width handling: 1. [zed-industries#51059](zed-industries#51059) - Extract modules into separate files (mechanical change) 2. [zed-industries#51120](zed-industries#51120) - Introduce width config enum for redistributable column widths (API rework) 3. **This PR**: Add independently resizable columns + fix variable list scrolling (new feature + bug fixes) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) This work is based on the [original draft PR zed-industries#44344](zed-industries#44344), decomposed into reviewable pieces. ----- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A or Added/Fixed/Improved ... --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

@Anthony-Eid

## Add variable row height mode to data table infrastructure This PR introduces support for variable row heights in the data table component, laying the groundwork for more flexible tabular data rendering in Zed. **Context:** This is the first in a series of infrastructure-focused PRs split out from the [original CSV preview draft PR](zed-industries#44344). The draft PR remains open as a reference and will be incrementally decomposed into smaller, reviewable pieces like this one. **Details:** - Adds a variable row height mode to the data table, enabling future features that require rows of differing heights (such as CSV preview and, eventually, database table views). - No user-facing changes; this is an internal refactor to support upcoming functionality. **Thanks:** Big thanks to @Anthony-Eid for pairing sessions and guidance on how to best structure and land these changes incrementally. --- Release Notes: - N/A (internal infrastructure change, no user impact)

…ed-industries#46341) This PR removes the const generics limitation from the data table component, enabling tables with a dynamic number of columns determined at runtime. **Context:** This is the next infrastructure step split out from the [original CSV preview draft PR](zed-industries#44344). The draft PR remains open as a reference and will continue to be decomposed into smaller, reviewable pieces. **Details:** - Introduces a `TableRow` newtype to enforce column count invariants at runtime, replacing the previous const generic approach. It's api surface is larger than is currently used, as it's planned to be used in CSV feature itself. - Refactors the data table and all usages (including the keymap editor) to work with runtime column counts. - This change is foundational for supporting CSV preview and other features that require flexible, dynamic tables. - Performance impact has not been formally measured, but there is no noticeable slowdown in practice. --- Release Notes: - N/A (internal infrastructure change, no user impact) --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

…dustries#48207) ## **Description:** **Context:** This PR introduces an initial CSV preview feature for Zed, building upon two previously merged infrastructure PRs: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support (removed const generics) - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables This implementation is based on the [original draft PR zed-industries#44344](zed-industries#44344), which has been carefully decomposed into smaller, reviewable pieces. --- #### **Features Included:** **Core Infrastructure:** - Live CSV parsing with smart debouncing (200ms cooldown) - Performance monitoring with built-in timing metrics (not displayed in UI yet) - Automatic file change detection and re-parsing - Support for quoted fields, multiline cells, and escaped characters **Table Display:** - Variable row height rendering with fallback to uniform mode (switchable via settings) - Draggable column resizing (reusing existing data table infrastructure) - Row identifiers supporting both source line numbers and sequential row numbers - Configurable font rendering (UI font vs monospace) - Tooltips showing full cell content on hover **Interactive Features:** - Column sorting (ascending/descending) with visual indicators **Settings Panel:** - Toggle between variable/uniform row rendering - Font type selection (UI/monospace) - Row identifier type configuration - Debug information display - Multiline cell rendering options --- #### **Features Intentionally Removed for This PR:** To reduce complexity and review scope, the following features were temporarily reverted and will be reintroduced in subsequent PRs: - ❌ Settings pannel with performance metrics overlay - ❌ Cell selection (single, multiple, and range selections) - ❌ Keyboard navigation with arrow keys and selection extension - ❌ Copy functionality supporting CSV, TSV, and Markdown table formats - ❌ Inline cell editing with file persistence - ❌ Viewport following for large datasets - ❌ Column filtering and search capabilities These removals were done via "time-machine" commits that cleanly nuked vertical slices of functionality from the complete implementation. --- **Technical Implementation:** The feature is organized into a dedicated `csv_preview` crate with the following structure: ``` crates/csv_preview/ ├── src/ │ ├── csv_preview.rs # Main view and coordination logic │ ├── parser.rs # CSV parsing and editor integration │ ├── settings.rs # Configuration types and defaults │ ├── table_data_engine.rs # Data transformation logic │ ├── renderer/ # UI rendering modules │ │ ├── preview_view.rs # Main render implementation │ │ ├── render_table.rs # Table component assembly │ │ ├── table_cell.rs # Individual cell rendering │ │ ├── table_header.rs # Header with sorting controls │ │ └── row_identifiers.rs # Line number column │ └── types/ # Core data structures │ ├── table_like_content.rs │ ├── coordinates.rs # Display vs data coordinate systems │ └── table_cell.rs ``` **Key architectural decisions:** - **Dual coordinate system**: Separates data indices from display indices to support sorting/filtering - **Component reuse**: Leverages existing `data_table` infrastructure from the keymap editor --- **Integration:** - Registers `csv::OpenPreview` action (currently without default keybindings) - Follows the same workspace integration pattern as `markdown_preview` and `svg_preview` - Automatically detects `.csv` file extensions - Tab integration with appropriate icons and naming --- **Code Structure Note:** Some code structures, types, and documentation may appear redundant or over-engineered in this initial implementation. This is intentional - the feature was developed as a complete system and then decomposed by functionality rather than being built incrementally. The "extra" infrastructure supports features that were removed for this PR but will be reintroduced in subsequent ones. This approach was chosen over extensive refactoring because: 1. The complete feature took 200+ commits to develop with significant rewrites 2. Clean extraction of vertical slices was more feasible than rebuilding incrementally 3. The end state will utilize all these components, making current "redundancy" temporary I apologize for any inconvenience this may cause during review, but the alternative would have required significant refactoring effort just to make intermediate states "prettier," which seemed counterproductive. --- **Future Work:** This lays the groundwork for upcoming PRs that will reintroduce the removed features: - Cell selection and keyboard navigation - Copy functionality with multiple output formats - Inline editing capabilities with undo/redo - Column filtering and search - TSV and other delimiter support - Improved horizontal scrolling behavior - Settings persistence **Testing:** Includes test fixtures demonstrating multiline cell handling, various column counts, and edge cases. --- **Release Notes:** - N/A This is feature flagged --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

This PR adds spreadsheet-style independently resizable columns (dragging changes total table width) and fixes scrolling issues in variable list mode. **What changed:** - Adds `ResizableColumnsState` struct for independently resizable columns (spreadsheet-style) - Adds `ColumnWidthConfig::Resizable` variant for spreadsheet mode - Adds `DraggedResizableColumn` drag payload type - Adds `ResizableHeaderInfo` for double-click-to-reset functionality - Adds `render_resize_handles_resizable` function for resize handles rendering - Adds horizontal scroll handle to `TableInteractionState` - Adds `.on_drag_move::<DraggedResizableColumn>` handler to Table for drag resizing **Bug fixes:** - Fixed missing vertical scrollbar in variable list mode - Fixed half-broken scrolling in variable list mode (added .measure_all() to make scrollbar aware of the height of the table) - Moved vertical scrollbar to be pinned at the right side of the pane with table — previously it was attached to the table content and was pushed off-screen when table content was too wide **API addition:** ```rust // New variant added: pub enum ColumnWidthConfig { Static { widths: StaticColumnWidths, table_width: Option<DefiniteLength> }, Redistributable { entity: Entity<RedistributableColumnsState>, table_width: Option<DefiniteLength> }, Resizable(Entity<ResizableColumnsState>), // NEW: spreadsheet-style } ``` **Callers updated:** - csv_preview: Changed from `ColumnWidthConfig::redistributable()` to use new resizable mode - git_graph: Added `resizable_info` parameter **Context:** This is part 3 of a 3-PR series improving data table column width handling: 1. [zed-industries#51059](zed-industries#51059) - Extract modules into separate files (mechanical change) 2. [zed-industries#51120](zed-industries#51120) - Introduce width config enum for redistributable column widths (API rework) 3. **This PR**: Add independently resizable columns + fix variable list scrolling (new feature + bug fixes) The series builds on previously merged infrastructure: - [zed-industries#46341](zed-industries#46341) - Data table dynamic column support - [zed-industries#46190](zed-industries#46190) - Variable row height mode for data tables Primary beneficiary: CSV preview feature ([zed-industries#48207](zed-industries#48207)) This work is based on the [original draft PR zed-industries#44344](zed-industries#44344), decomposed into reviewable pieces. ----- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #ISSUE Release Notes: - N/A or Added/Fixed/Improved ... --------- Co-authored-by: Anthony Eid <anthony@zed.dev>

cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Dec 7, 2025

HalavicH force-pushed the lab/csv-preview branch 2 times, most recently from 3bcf33b to dc1fe10 Compare December 12, 2025 17:59

HalavicH force-pushed the lab/csv-preview branch 2 times, most recently from c37860f to 3e245c0 Compare December 28, 2025 19:42

HalavicH mentioned this pull request Jan 6, 2026

data_table: #1 Add variable row height mode to table UI element #46190

Merged

HalavicH mentioned this pull request Jan 8, 2026

data_table: #2 Remove const generics from data table (runtime column count support) #46341

Merged

HalavicH and others added 17 commits January 9, 2026 12:59

feat: Add scaffolding with dummy pane content

b6005c7

feat: Vibe code ascii implementation

cefeb90

feat: Init CSV preview

1fea39b

feat: Add counter to POC interactivity

71288b3

feat: Switch to proper table rendering

adb75f7

feat: Add runtime change of column width

a9e29b3

feat: Snatch column resizing implementation from "Keymap Editor"

d35ca6b

feat: Update tab name

f228048

feat: Add live-reload for CSV preview

bdde7ef

refactor: Extract parser and renderer modules

728b743

[sort] feat: Add POC ordering for 0th column

10f2a81

[linenums] feat: Add POC line numbers

36638f4

[sort] feat: Add ordering for all columns

bd34cc8

[selection] feat: Add experimental drag to select

0022c46

[linenums] feat: Add dynamic but fixed width for line numbers

b36e1cb

[selection] fix: Update selection to handle sorted data correctly

3dbb0f0

[selection] refactor: Move to separate module

b219479

HalavicH added 7 commits January 9, 2026 12:59

fix: Update unit tests

8c5c85d

dt: Rename table widths

5d06182

[data_table] Implement table width modes

c46615c

[data_table] poc of column defined table width

87d3660

POC: Add switch between resize modes

015fe74

feat: Add switch for column resize mode

2257808

fix: Address some clippy warnings

820f475

HalavicH force-pushed the lab/csv-preview branch from 3e245c0 to 820f475 Compare January 9, 2026 11:59

HalavicH mentioned this pull request Feb 2, 2026

csv_preview: #1 Add CSV preview with live table view and interactive features #48207

Merged

mikayla-maki closed this Feb 4, 2026

HalavicH changed the title ~~[POC] CSV/TSV preview (as stepping stone for database client)~~ [Reference POC] CSV/TSV preview (Actual development happens in separate PRs) Feb 10, 2026

HalavicH mentioned this pull request Mar 8, 2026

data_table: #3 Extract table_row & tests modules to separate files #51059

Merged

HalavicH mentioned this pull request Apr 7, 2026

data_table: #5 Add independently resizable columns + fix variable list scrolling #53295

Merged

5 tasks

Navigation Menu

Uh oh!

Uh oh!

[Reference POC] CSV/TSV preview (Actual development happens in separate PRs) - #44344

[Reference POC] CSV/TSV preview (Actual development happens in separate PRs)#44344
HalavicH wants to merge 190 commits into
zed-industries:mainfrom
HalavicH:lab/csv-preview

HalavicH commented Dec 7, 2025 •

edited

Loading

Uh oh!

zed-industries-bot commented Dec 7, 2025 •

edited

Loading

Uh oh!

jaczanet commented Jan 8, 2026

Uh oh!

theVedanta commented Jan 19, 2026

Uh oh!

HalavicH commented Jan 20, 2026

Uh oh!

mikayla-maki commented Feb 4, 2026

Uh oh!

HalavicH commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

HalavicH commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I’m proposing this

Status

Current features

Demos

Implementation notes

Future roadmap

Release Notes

Uh oh!

zed-industries-bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jaczanet commented Jan 8, 2026

Uh oh!

theVedanta commented Jan 19, 2026

Uh oh!

HalavicH commented Jan 20, 2026

Uh oh!

mikayla-maki commented Feb 4, 2026

Uh oh!

HalavicH commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

HalavicH commented Dec 7, 2025 •

edited

Loading

zed-industries-bot commented Dec 7, 2025 •

edited

Loading